Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables


Copy link to this message
-
Re: Review Request 11334: HIVE-4568 Beeline needs to support resolving variables

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11334/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 12:15 a.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------

I think I forgot to update the diff when patch HIVE-4568.3.patch was attached to the JIRA, which caused some confusion in the review comments. Now it's updated with latest review comments. Please review again to see if there is still anything missing. Thanks.
Bugs: HIVE-4568
    https://issues.apache.org/jira/browse/HIVE-4568
Repository: hive-git
Description
-------

1. Added command variable substition
2. Added test case
Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java 4c6eb9b
  beeline/src/java/org/apache/hive/beeline/BeeLine.properties b6650cf
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 61bdeee
  beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java c70003d
  beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java 030f6b0

Diff: https://reviews.apache.org/r/11334/diff/
Testing
-------
Thanks,

Xuefu Zhang