Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Hive, mail # dev - Review Request: Add 'show version' command to Hive CLI


+
Zhuoluo Yang 2013-01-15, 13:14
Copy link to this message
-
Re: Review Request: Add 'show version' command to Hive CLI
Brock Noland 2013-01-15, 17:29

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8958/#review15348
-----------------------------------------------------------
Hi, looks good! A few comments below.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/8958/#comment33014>

    Is their a reason we just use the exceptions message? I feel we are losing valuable information by eating the stack trace.

http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh
<https://reviews.apache.org/r/8958/#comment33015>

    Excuse me for my likely ignorance, but is ant setting the cwd variable?
- Brock Noland
On Jan. 15, 2013, 1:14 p.m., Zhuoluo Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8958/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 1:14 p.m.)
>
>
> Review request for hive and Carl Steinbach.
>
>
> Description
> -------
>
> We add a simple ddl grammar, called "show version".
> The version info is generated automatically while compiling.
>
>
> This addresses bug HIVE-1151.
>     https://issues.apache.org/jira/browse/HIVE-1151
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/hive/trunk/build.xml 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/HiveVersionAnnotation.java PRE-CREATION
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java 1433285
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ShowVersionDesc.java PRE-CREATION
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/util/HiveVersionInfo.java PRE-CREATION
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/saveVersion.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8958/diff/
>
>
> Testing
> -------
>
> $hive
> Hive history file=/tmp/zhuoluo/hive_job_log_zhuoluo_201301152113_1633688174.txt
> hive> show version;
> OK
> 0.11.0-SNAPSHOT from 1432865 by zhuoluo on Tue Jan 15 20:58:42 CST 2013
> http://svn.apache.org/repos/asf/hive/trunk
> Time taken: 0.279 seconds, Fetched: 2 row(s)
> hive>
>
>
> Thanks,
>
> Zhuoluo Yang
>
>

+
Zhuoluo Yang 2013-01-16, 04:44
+
Zhuoluo Yang 2013-01-16, 04:50
+
Brock Noland 2013-01-17, 01:55
+
Zhuoluo Yang 2013-01-18, 06:28
+
Zhuoluo Yang 2013-01-18, 06:28
+
Brock Noland 2013-02-07, 19:59
+
Brock Noland 2013-02-07, 19:59