Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 13262: HIVE-4573: JDBC Compliance getTables


Copy link to this message
-
Re: Review Request 13262: HIVE-4573: JDBC Compliance getTables


> On Aug. 4, 2013, 9:23 a.m., Gunther Hagleitner wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 741
> > <https://reviews.apache.org/r/13262/diff/1/?file=336851#file336851line741>
> >
> >     "" is confusing. Default is "HIVE" right? I also think that the hive-site template should be updated with a description of the variable.

Changed to HIVE.
> On Aug. 4, 2013, 9:23 a.m., Gunther Hagleitner wrote:
> > service/src/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java, line 61
> > <https://reviews.apache.org/r/13262/diff/1/?file=336853#file336853line61>
> >
> >     test seems unnecessary. private final can't change to null.

It's just checking the arguments, though not really needed.
Fixed.
> On Aug. 4, 2013, 9:23 a.m., Gunther Hagleitner wrote:
> > service/src/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java, line 73
> > <https://reviews.apache.org/r/13262/diff/1/?file=336853#file336853line73>
> >
> >     see above

Done
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13262/#review24629
-----------------------------------------------------------
On Aug. 4, 2013, 1:03 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13262/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2013, 1:03 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-4573
>     https://issues.apache.org/jira/browse/HIVE-4573
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support alternate table type name for GetTables() and GetTableTypes().
> Currently HiveServer2 supports Hive's native table type names eg. MANAGED_TABLE, VIRTUAL_VIEW etc. The more common terms used by various DB vendors and tools are TABLE and VIEW. This makes it difficult to integrate Hive with various tools or custom applications.
> The patch introduces an alternate table type name mapping that can be configured at instance level or session level.
>
>
> Diffs
> -----
>
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 555343e
>   jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver2.java 1042125
>   service/src/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java PRE-CREATION
>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java eaf867e
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java d9d0e9c
>   service/src/java/org/apache/hive/service/cli/operation/HiveTableTypeMapping.java PRE-CREATION
>   service/src/java/org/apache/hive/service/cli/operation/TableTypeMapping.java PRE-CREATION
>   service/src/java/org/apache/hive/service/cli/operation/TableTypeMappingFactory.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13262/diff/
>
>
> Testing
> -------
>
> Added test cases in TestJdbcDriver2.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>