Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Avro, mail # dev - Re: [jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations


Copy link to this message
-
Re: [jira] [Commented] (AVRO-1007) Insufficient validation in generated specific record builder implementations
Scott Carey 2012-02-08, 20:04
Your email address is registered with the avro-dev mailing list.
See:
http://avro.apache.org/mailing_lists.html

You would not be able to send mail to this list if you were not
subscribed.  

On 2/8/12 11:40 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:

>Why am I on this email string? Please remove me.
>
>--- On Wed, 2/8/12, Scott Carey (Commented) (JIRA) <[EMAIL PROTECTED]>
>wrote:
>
>From: Scott Carey (Commented) (JIRA) <[EMAIL PROTECTED]>
>Subject: [jira] [Commented] (AVRO-1007) Insufficient validation in
>generated specific record builder implementations
>To: [EMAIL PROTECTED]
>Date: Wednesday, February 8, 2012, 2:38 PM
>
>
>    [
>https://issues.apache.org/jira/browse/AVRO-1007?page=com.atlassian.jira.pl
>ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203889#comm
>ent-13203889 ]
>
>Scott Carey commented on AVRO-1007:
>-----------------------------------
>
>Slight clarification:
>
>The schema above has worked for me in the past, but I am not sure if it
>has _always_ worked -- that was too strong of a statement.
>                
>> Insufficient validation in generated specific record builder
>>implementations
>>
>>-------------------------------------------------------------------------
>>---
>>
>>                 Key: AVRO-1007
>>                 URL: https://issues.apache.org/jira/browse/AVRO-1007
>>             Project: Avro
>>          Issue Type: Bug
>>    Affects Versions: 1.6.1
>>            Reporter: James Baldassari
>>            Assignee: James Baldassari
>>              Labels: java
>>             Fix For: 1.6.2
>>
>>         Attachments: AVRO-1007-v2.patch, AVRO-1007-v3.patch,
>>AVRO-1007-v4.patch, AVRO-1007.patch, AVRO-1007.patch, AVRO-1007.patch
>>
>>
>> The are two main problems with the generated build() method in specific
>>record builders:
>> * For non-primitive types, if there is no default value and the user
>>does not set the value, build() will execute successfully without
>>throwing an exception
>> ** Instead, an AvroRuntimeException should be thrown with an exception
>>message indicating the name of the required field that was not set
>> * For primitive types, if there is no default value and the user does
>>not set the value, an AvroRuntimeException is thrown with the 'cause'
>>set to a NullPointerException, which is not very helpful
>> ** The NPE comes from attempting to set the primitive field to the
>>result of defaultValue(), which is null
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA
>administrators:
>https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>