Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end


Copy link to this message
-
Re: Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end
Eric Newton 2013-10-29, 13:38

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15002/#review27674
-----------------------------------------------------------
The boolean used to shutdown needs to be protected by locks, or needs to be an AtomicBoolean.  The jvm will take liberties and not push the change out of caches and into the view of other threads, otherwise.

- Eric Newton
On Oct. 28, 2013, 10:54 p.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15002/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 10:54 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1307
>     https://issues.apache.org/jira/browse/ACCUMULO-1307
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> First pass at shutting down FATE. Maybe makes sense to daemonize the thread and add a daemonized monitor thread that 'manages' them somehow in case operation is stuck?
>
>
> Diffs
> -----
>
>   fate/src/main/java/org/apache/accumulo/fate/Fate.java bd36edb
>   server/src/main/java/org/apache/accumulo/server/master/Master.java 2c19b6f
>
> Diff: https://reviews.apache.org/r/15002/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Vines
>
>