|
|
-
Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Todd Lipcon 2011-09-09, 03:39
I plan to push the following patches to branch-0.23 tomorrow morning unless there's any objection: HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) HDFS-2197. Refactor RPC call implementations out of NameNode class. Contributed by Todd Lipcon. HDFS-2314. MRV1 test compilation broken after HDFS-2197. Contributed by Todd Lipcon The motivation is that the rename in HDFS-1620 touched most of the files in HDFS and will cause future backports to have a lot of conflicts unless we backport this one. HDFS-2197 moved all of the RPC methods out of NameNode.java to a new class, and hence would cause conflicts on any future changes that affect the NN RPC. 2314 is a simple bugfix on 2197. The backports were straightforward so I'll assume it doesn't need a separate review. If you'd like to take a look, I pushed a tree here: https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197Thanks -Todd -- Todd Lipcon Software Engineer, Cloudera
+
Todd Lipcon 2011-09-09, 03:39
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Arun C Murthy 2011-09-09, 03:42
Todd, HDFS-1620 breaks Raid compile... On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: > I plan to push the following patches to branch-0.23 tomorrow morning > unless there's any objection: > HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, > FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) > HDFS-2197. Refactor RPC call implementations out of NameNode > class. Contributed by Todd Lipcon. > HDFS-2314. MRV1 test compilation broken after HDFS-2197. > Contributed by Todd Lipcon > > The motivation is that the rename in HDFS-1620 touched most of the > files in HDFS and will cause future backports to have a lot of > conflicts unless we backport this one. HDFS-2197 moved all of the RPC > methods out of NameNode.java to a new class, and hence would cause > conflicts on any future changes that affect the NN RPC. 2314 is a > simple bugfix on 2197. > > The backports were straightforward so I'll assume it doesn't need a > separate review. If you'd like to take a look, I pushed a tree here: > https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197> > Thanks > -Todd > -- > Todd Lipcon > Software Engineer, Cloudera
+
Arun C Murthy 2011-09-09, 03:42
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Todd Lipcon 2011-09-09, 03:44
Ah, thanks for the headsup. I'll find the appropriate fix for that and backport that as well. On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: > Todd, HDFS-1620 breaks Raid compile... > > On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: > >> I plan to push the following patches to branch-0.23 tomorrow morning >> unless there's any objection: >> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >> HDFS-2197. Refactor RPC call implementations out of NameNode >> class. Contributed by Todd Lipcon. >> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >> Contributed by Todd Lipcon >> >> The motivation is that the rename in HDFS-1620 touched most of the >> files in HDFS and will cause future backports to have a lot of >> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >> methods out of NameNode.java to a new class, and hence would cause >> conflicts on any future changes that affect the NN RPC. 2314 is a >> simple bugfix on 2197. >> >> The backports were straightforward so I'll assume it doesn't need a >> separate review. If you'd like to take a look, I pushed a tree here: >> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>> >> Thanks >> -Todd >> -- >> Todd Lipcon >> Software Engineer, Cloudera > > -- Todd Lipcon Software Engineer, Cloudera
+
Todd Lipcon 2011-09-09, 03:44
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Arun C Murthy 2011-09-09, 03:47
I think Nic is on it (MR-2711, thanks Nic). But pls check to ensure 'ant binary' works in MR before committing. thanks, Arun On Sep 8, 2011, at 8:44 PM, Todd Lipcon wrote: > Ah, thanks for the headsup. I'll find the appropriate fix for that and > backport that as well. > > On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: >> Todd, HDFS-1620 breaks Raid compile... >> >> On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: >> >>> I plan to push the following patches to branch-0.23 tomorrow morning >>> unless there's any objection: >>> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >>> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >>> HDFS-2197. Refactor RPC call implementations out of NameNode >>> class. Contributed by Todd Lipcon. >>> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >>> Contributed by Todd Lipcon >>> >>> The motivation is that the rename in HDFS-1620 touched most of the >>> files in HDFS and will cause future backports to have a lot of >>> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >>> methods out of NameNode.java to a new class, and hence would cause >>> conflicts on any future changes that affect the NN RPC. 2314 is a >>> simple bugfix on 2197. >>> >>> The backports were straightforward so I'll assume it doesn't need a >>> separate review. If you'd like to take a look, I pushed a tree here: >>> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>>> >>> Thanks >>> -Todd >>> -- >>> Todd Lipcon >>> Software Engineer, Cloudera >> >> > > > > -- > Todd Lipcon > Software Engineer, Cloudera
+
Arun C Murthy 2011-09-09, 03:47
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Arun C Murthy 2011-09-09, 03:51
Sorry, it isn't MR-2711, but I'm talking to Nic about the same... On Sep 8, 2011, at 8:47 PM, Arun C Murthy wrote: > I think Nic is on it (MR-2711, thanks Nic). > > But pls check to ensure 'ant binary' works in MR before committing. > > thanks, > Arun > > On Sep 8, 2011, at 8:44 PM, Todd Lipcon wrote: > >> Ah, thanks for the headsup. I'll find the appropriate fix for that and >> backport that as well. >> >> On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: >>> Todd, HDFS-1620 breaks Raid compile... >>> >>> On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: >>> >>>> I plan to push the following patches to branch-0.23 tomorrow morning >>>> unless there's any objection: >>>> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >>>> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >>>> HDFS-2197. Refactor RPC call implementations out of NameNode >>>> class. Contributed by Todd Lipcon. >>>> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >>>> Contributed by Todd Lipcon >>>> >>>> The motivation is that the rename in HDFS-1620 touched most of the >>>> files in HDFS and will cause future backports to have a lot of >>>> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >>>> methods out of NameNode.java to a new class, and hence would cause >>>> conflicts on any future changes that affect the NN RPC. 2314 is a >>>> simple bugfix on 2197. >>>> >>>> The backports were straightforward so I'll assume it doesn't need a >>>> separate review. If you'd like to take a look, I pushed a tree here: >>>> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>>>> >>>> Thanks >>>> -Todd >>>> -- >>>> Todd Lipcon >>>> Software Engineer, Cloudera >>> >>> >> >> >> >> -- >> Todd Lipcon >> Software Engineer, Cloudera >
+
Arun C Murthy 2011-09-09, 03:51
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Tsz Wo Sze 2011-09-09, 04:03
The JIRA is MAPREDUCE-2936. Contrib Raid compilation broken after HDFS-1620. Nicholas ________________________________ From: Arun C Murthy <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Sent: Thursday, September 8, 2011 8:51 PM Subject: Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23 Sorry, it isn't MR-2711, but I'm talking to Nic about the same... On Sep 8, 2011, at 8:47 PM, Arun C Murthy wrote: > I think Nic is on it (MR-2711, thanks Nic). > > But pls check to ensure 'ant binary' works in MR before committing. > > thanks, > Arun > > On Sep 8, 2011, at 8:44 PM, Todd Lipcon wrote: > >> Ah, thanks for the headsup. I'll find the appropriate fix for that and >> backport that as well. >> >> On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: >>> Todd, HDFS-1620 breaks Raid compile... >>> >>> On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: >>> >>>> I plan to push the following patches to branch-0.23 tomorrow morning >>>> unless there's any objection: >>>> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >>>> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >>>> HDFS-2197. Refactor RPC call implementations out of NameNode >>>> class. Contributed by Todd Lipcon. >>>> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >>>> Contributed by Todd Lipcon >>>> >>>> The motivation is that the rename in HDFS-1620 touched most of the >>>> files in HDFS and will cause future backports to have a lot of >>>> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >>>> methods out of NameNode.java to a new class, and hence would cause >>>> conflicts on any future changes that affect the NN RPC. 2314 is a >>>> simple bugfix on 2197. >>>> >>>> The backports were straightforward so I'll assume it doesn't need a >>>> separate review. If you'd like to take a look, I pushed a tree here: >>>> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>>>> >>>> Thanks >>>> -Todd >>>> -- >>>> Todd Lipcon >>>> Software Engineer, Cloudera >>> >>> >> >> >> >> -- >> Todd Lipcon >> Software Engineer, Cloudera >
+
Tsz Wo Sze 2011-09-09, 04:03
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Harsh J 2011-09-09, 05:54
Yep, thanks Vinod for fixing up after HDFS-1620! HDFS-1620 should be accompanied with MAPREDUCE-2936, and then it should be good. On Fri, Sep 9, 2011 at 9:33 AM, Tsz Wo Sze <[EMAIL PROTECTED]> wrote: > The JIRA is MAPREDUCE-2936. Contrib Raid compilation broken after HDFS-1620. > Nicholas > > > > ________________________________ > From: Arun C Murthy <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Sent: Thursday, September 8, 2011 8:51 PM > Subject: Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23 > > Sorry, it isn't MR-2711, but I'm talking to Nic about the same... > > On Sep 8, 2011, at 8:47 PM, Arun C Murthy wrote: > >> I think Nic is on it (MR-2711, thanks Nic). >> >> But pls check to ensure 'ant binary' works in MR before committing. >> >> thanks, >> Arun >> >> On Sep 8, 2011, at 8:44 PM, Todd Lipcon wrote: >> >>> Ah, thanks for the headsup. I'll find the appropriate fix for that and >>> backport that as well. >>> >>> On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: >>>> Todd, HDFS-1620 breaks Raid compile... >>>> >>>> On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: >>>> >>>>> I plan to push the following patches to branch-0.23 tomorrow morning >>>>> unless there's any objection: >>>>> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >>>>> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >>>>> HDFS-2197. Refactor RPC call implementations out of NameNode >>>>> class. Contributed by Todd Lipcon. >>>>> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >>>>> Contributed by Todd Lipcon >>>>> >>>>> The motivation is that the rename in HDFS-1620 touched most of the >>>>> files in HDFS and will cause future backports to have a lot of >>>>> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >>>>> methods out of NameNode.java to a new class, and hence would cause >>>>> conflicts on any future changes that affect the NN RPC. 2314 is a >>>>> simple bugfix on 2197. >>>>> >>>>> The backports were straightforward so I'll assume it doesn't need a >>>>> separate review. If you'd like to take a look, I pushed a tree here: >>>>> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>>>>> >>>>> Thanks >>>>> -Todd >>>>> -- >>>>> Todd Lipcon >>>>> Software Engineer, Cloudera >>>> >>>> >>> >>> >>> >>> -- >>> Todd Lipcon >>> Software Engineer, Cloudera >> -- Harsh J
+
Harsh J 2011-09-09, 05:54
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Todd Lipcon 2011-09-12, 19:36
Hi all, I merged the four patches mentioned in this thread to 0.23. Thanks -Todd On Thu, Sep 8, 2011 at 10:54 PM, Harsh J <[EMAIL PROTECTED]> wrote: > Yep, thanks Vinod for fixing up after HDFS-1620! > > HDFS-1620 should be accompanied with MAPREDUCE-2936, and then it should be good. > > On Fri, Sep 9, 2011 at 9:33 AM, Tsz Wo Sze <[EMAIL PROTECTED]> wrote: >> The JIRA is MAPREDUCE-2936. Contrib Raid compilation broken after HDFS-1620. >> Nicholas >> >> >> >> ________________________________ >> From: Arun C Murthy <[EMAIL PROTECTED]> >> To: [EMAIL PROTECTED] >> Sent: Thursday, September 8, 2011 8:51 PM >> Subject: Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23 >> >> Sorry, it isn't MR-2711, but I'm talking to Nic about the same... >> >> On Sep 8, 2011, at 8:47 PM, Arun C Murthy wrote: >> >>> I think Nic is on it (MR-2711, thanks Nic). >>> >>> But pls check to ensure 'ant binary' works in MR before committing. >>> >>> thanks, >>> Arun >>> >>> On Sep 8, 2011, at 8:44 PM, Todd Lipcon wrote: >>> >>>> Ah, thanks for the headsup. I'll find the appropriate fix for that and >>>> backport that as well. >>>> >>>> On Thu, Sep 8, 2011 at 8:42 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: >>>>> Todd, HDFS-1620 breaks Raid compile... >>>>> >>>>> On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote: >>>>> >>>>>> I plan to push the following patches to branch-0.23 tomorrow morning >>>>>> unless there's any objection: >>>>>> HDFS-1620. Rename HdfsConstants -> HdfsServerConstants, >>>>>> FSConstants -> HdfsConstants. (Harsh J Chouraria via atm) >>>>>> HDFS-2197. Refactor RPC call implementations out of NameNode >>>>>> class. Contributed by Todd Lipcon. >>>>>> HDFS-2314. MRV1 test compilation broken after HDFS-2197. >>>>>> Contributed by Todd Lipcon >>>>>> >>>>>> The motivation is that the rename in HDFS-1620 touched most of the >>>>>> files in HDFS and will cause future backports to have a lot of >>>>>> conflicts unless we backport this one. HDFS-2197 moved all of the RPC >>>>>> methods out of NameNode.java to a new class, and hence would cause >>>>>> conflicts on any future changes that affect the NN RPC. 2314 is a >>>>>> simple bugfix on 2197. >>>>>> >>>>>> The backports were straightforward so I'll assume it doesn't need a >>>>>> separate review. If you'd like to take a look, I pushed a tree here: >>>>>> https://github.com/toddlipcon/hadoop-common/tree/branch-0.23-backport-2197>>>>>> >>>>>> Thanks >>>>>> -Todd >>>>>> -- >>>>>> Todd Lipcon >>>>>> Software Engineer, Cloudera >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Todd Lipcon >>>> Software Engineer, Cloudera >>> > > > > -- > Harsh J > -- Todd Lipcon Software Engineer, Cloudera
+
Todd Lipcon 2011-09-12, 19:36
-
Re: Backporting HDFS-1620, HDFS-2197, HDFS-2314 to branch-0.23
Allen Wittenauer 2011-09-16, 23:15
On Sep 8, 2011, at 8:39 PM, Todd Lipcon wrote:
>
> The motivation is that the rename in HDFS-1620 touched most of the
> files in HDFS and will cause future backports to have a lot of
> conflicts unless we backport this one.
That sounds like a postive to me. If it is hard to backport, then that makes the desire to go forward greater.
+
Allen Wittenauer 2011-09-16, 23:15
|
|
