Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request 15163: FLUME-2217 Preserve priority, timestamp and hostname fields in MultiportSyslogTcp, SyslogTcp and Udp sources


+
Jeff jlord 2013-11-01, 00:43
Copy link to this message
-
Re: Review Request 15163: FLUME-2217 Preserve priority, timestamp and hostname fields in MultiportSyslogTcp, SyslogTcp and Udp sources
Jeff jlord 2013-11-01, 14:20

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15163/
-----------------------------------------------------------

(Updated Nov. 1, 2013, 2:20 p.m.)
Review request for Flume, Hari Shreedharan and Mike Percy.
Repository: flume-git
Description
-------

Here is a first pass at this.
Please not that the functionality of all 3 sources was modified slightly such that with this patch we will now preserve the syslog priority as well as the timestamp and header. e.g.
<10>2013-10-31T17:36:27.381-07:00 localhost.localdomain test UDP syslog data
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/MultiportSyslogTCPSource.java 884fd62
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogParser.java bf3305c
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 7a12d27
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
  flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java f2ea932
  flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java 680e592
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java 258c2f1
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java a6a1d5b
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java eae26ed
  flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java 898096b
  flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67

Diff: https://reviews.apache.org/r/15163/diff/
Testing
-------

Added a brand new TestSyslogUdp Class to verify functionality.
Updated Syslog parser test to verify as well.
Thanks,

Jeff jlord

+
Jeff jlord 2013-11-02, 21:45
+
Jeff jlord 2013-11-02, 21:47
+
Jeff jlord 2013-11-02, 21:51
+
Jeff jlord 2013-11-06, 01:49
+
Mike Percy 2013-12-04, 03:39
+
Jeff jlord 2013-12-09, 23:03
+
Jeff jlord 2013-12-09, 23:04
+
Jeff jlord 2013-12-09, 23:53
+
Jeff jlord 2013-12-10, 00:23
+
Mike Percy 2013-12-10, 22:26
+
Mike Percy 2013-11-01, 23:28