I believe the practice is 'review then commit for anything substantial
that might have negative effects.' And the logic is that if there's a
patch that'll break somebody's production deployment, they should have
the chance to object.
I do not believe CHUKWA-685 required review before commit.
On Sat, Apr 13, 2013 at 10:52 PM, Luciano Resende <[EMAIL PROTECTED]> wrote:
> I just saw CHUKWA-685 and was wondering if this project is using Review
> Then Commit (RTC) for all it's change, and if so, any specific reason for
> doing so ?
> Luciano Resende
Ari Rabkin [EMAIL PROTECTED]
Princeton Computer Science Department