Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1360: Provide documentation for static interceptor


Copy link to this message
-
Re: Review Request: FLUME-1360: Provide documentation for static interceptor
Patrick Wendell 2012-07-16, 16:31

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5879/#review9173
-----------------------------------------------------------
Looked over the static interceptor. Some grammar issues are noted. Overall, the documentation correctly conforms to the implementation.
/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19633>

    "to append static header" --> "to append a static header"

/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19634>

    --> "The current implementation does not..."

/trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst
<https://reviews.apache.org/r/5879/#comment19636>

    This comma should be removed.
- Patrick Wendell
On July 13, 2012, 1:57 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5879/
> -----------------------------------------------------------
>
> (Updated July 13, 2012, 1:57 p.m.)
>
>
> Review request for Flume, Arvind Prabhakar, Juhani Connolly, Mike Percy, and Hari Shreedharan.
>
>
> Description
> -------
>
> I've documented static interceptor and I also put some examples to other interceptors as well.
>
>
> This addresses bug FLUME-1360.
>     https://issues.apache.org/jira/browse/FLUME-1360
>
>
> Diffs
> -----
>
>   /trunk/flume-ng-doc/sphinx/FlumeUserGuide.rst 1359503
>
> Diff: https://reviews.apache.org/r/5879/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>