Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: Fixes the problem with RollingFileSink being unable to resume on reconfiguration


+
Roshan Naik 2012-11-30, 21:23
+
Roshan Naik 2012-11-30, 21:23
Copy link to this message
-
Re: Review Request: Fixes the problem with RollingFileSink being unable to resume on reconfiguration
Brock Noland 2012-12-07, 15:34

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8297/#review14150
-----------------------------------------------------------
This looks good, I will run the commit tests.

- Brock Noland
On Nov. 30, 2012, 9:23 p.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8297/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2012, 9:23 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
>  - nulling out outputStream in  RollingFileSink.stop()   [ here we rely on the invariant that outputStream==null  implies  serializer==null ]
>  - removing superfluous calls to outputStream.flush()
>
>
> This addresses bug https://issues.apache.org/jira/browse/FLUME-1175.
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1175
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java be640bb
>
> Diff: https://reviews.apache.org/r/8297/diff/
>
>
> Testing
> -------
>
> ran RollingFileSink tests
>
>
> Thanks,
>
> Roshan Naik
>
>

+
Brock Noland 2012-12-07, 16:12