Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution


Copy link to this message
-
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution
Sergey Shelukhin 2013-11-27, 02:22

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29471
-----------------------------------------------------------

ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
<https://reviews.apache.org/r/15869/#comment56702>

    disregard this part of the comment (and below)
- Sergey Shelukhin
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
>   ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
>   ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
>   ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
>   ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
>   ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>