Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: Sqoop2: Export sub directories option


Copy link to this message
-
Re: Review Request: Sqoop2: Export sub directories option
Jarek Cecho 2013-06-02, 19:13

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11588/#review21303
-----------------------------------------------------------
Hi Vasanth,
thank you very much for taking this one!
core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java
<https://reviews.apache.org/r/11588/#comment44201>

    Size parameter for EnumInput is not used, so I would recommend removing it from the annotation.

execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
<https://reviews.apache.org/r/11588/#comment44203>

    I think that there is no reason to serialize this information into the Mapreduce config object. It should be retrieved from the Configuration object itself now where we are correctly passing the objects through entire mapreduce execution, right?

execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
<https://reviews.apache.org/r/11588/#comment44202>

    Shouldn't this condition use logical or instead of and?
Jarcec

- Jarek Cecho
On June 1, 2013, 12:17 p.m., vasanthkumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11588/
> -----------------------------------------------------------
>
> (Updated June 1, 2013, 12:17 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
>
> Introducing new option for exporting the sub directories of the given input directory.
>
> Added new input
> Input configuration
>
> Input directory: /input
> Recursive:
>   0 : NO
>   1 : YES
> Choose: 0
>
>
> This addresses bug SQOOP-1063.
>     https://issues.apache.org/jira/browse/SQOOP-1063
>
>
> Diffs
> -----
>
>   core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java d5cbeec
>   core/src/main/resources/framework-resources.properties cebc90e
>   execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java 767080c
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/JobConstants.java e2b3ce8
>   execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java b3590dc
>   execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java b3e6050
>
> Diff: https://reviews.apache.org/r/11588/diff/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> vasanthkumar
>
>