Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill, mail # dev - Review Request 14764: Patch for DRILL-230


Copy link to this message
-
Re: Review Request 14764: Patch for DRILL-230
Steven Phillips 2013-10-25, 12:15

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14764/
-----------------------------------------------------------

(Updated Oct. 25, 2013, 12:15 p.m.)
Review request for drill.
Bugs: DRILL-230
    https://issues.apache.org/jira/browse/DRILL-230
Repository: drill-git
Description (updated)
-------

DRILL-230: address additional code review comments
DRILL-230: Addressing comments in code review, abstract out references to HazelCache and add comments
DRILL-230: Build a sampling range partitioner
DRILL-264: MappingSets should not be static
DRILL-242: fix negative hash values, sort order POP case and sending of empty batches with no schema
DRILL-263: PartitionSender not setting opposite minor fragment id correctly
Diffs (updated)
-----

  common/src/main/java/org/apache/drill/common/expression/OutputTypeDeterminer.java ed227ec4a958077922bbcf943f5dcadc1b05686e
  common/src/main/java/org/apache/drill/common/util/DataInputInputStream.java PRE-CREATION
  common/src/main/java/org/apache/drill/common/util/DataOutputOutputStream.java PRE-CREATION
  exec/java-exec/pom.xml f6543f9b63bd3385fb0dfefa2b2367c1eab97484
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/Counter.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedCache.java d1b0e89adc373b0d515860f5985d88e5203d8a65
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMap.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/DistributedMultiMap.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/DrillSerializable.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCDrillSerializableWrapper.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/HCSerializableWrapperClasses.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/HazelCache.java 22435bd0396726860b6b30657787098f4a4d94c7
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/LocalCache.java 79675c3a6c2c573941d965a62da73d9447ee90e5
  exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorContainerSerializable.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 3dadb0cc87c7d234cc545acec505aab46fe689e1
  exec/java-exec/src/main/java/org/apache/drill/exec/client/QuerySubmitter.java 835b9b5469dc17036089bd80062e313853a3de60
  exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java bb9fc251f38f95c0e7174c934408cd99456a2286
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 286144bdefdff60d665186bc4730b3123981f006
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java a36b65a012f9b86c584609f18f45cae259046906
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionExchange.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedPartitionSender.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java 94acc0e1a7f96e61cab1f0218204aa3957cbbf89
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java 10d595a509cbeac4f45a7d57276834f207c21ea0
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/WireRecordBatch.java 5f8b4167db98f934a05c27822cec50bb7af71036
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/AggBatch.java 8618b7f7768259db6c0a9ee9d2578532239e30b1
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionBatchCreator.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionProjector.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionProjectorTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/SampleCopier.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/SampleCopierTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/SampleSortTemplate.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/SampleSorter.java PRE-CREATION
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/OutgoingRecordBatch.java 2940dc002c72deb9531ae55b3123e77d30c24e61
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionSenderRootExec.java 033dd5192c4f5b03a581161148e83f15d9391188
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java 2386dc2915e333a7d1e869adc6e6ed08adf13962
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/RecordBatchData.java 1226e850582a87171efacd755abc8c63206480b1
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortBatch.java 3fd590c340b52874bbccf258337c30f720407218
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortRecordBatchBuilder.java 88737929847c27279993e174cdc5fccf818ce8de
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/SortTemplate.java 43ed7e47c8ac04e6f790c0c07089853e046761a2
  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/Sorter.java 2099a7c948657261a50f35bfa90b99fb29ab08c3
  exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java 30a3d5af66e08c06f2e7455e93b9b4d051080592
  exec/java-exec/src/main/java/org/apache/drill/exec/record/Abs