Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: Fix to get version info working on windows


+
Roshan Naik 2013-05-29, 06:59
Copy link to this message
-
Re: Review Request: Fix to get version info working on windows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11509/#review21152
-----------------------------------------------------------

Ship it!
+1, good work!

- Alexander Alten-Lorenz
On May 29, 2013, 6:59 a.m., Roshan Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11509/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 6:59 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> added saveVersion.ps1 powershell script
> added windows maven profile to run this script at build time
>
>
> This addresses bug FLUME-2054.
>     https://issues.apache.org/jira/browse/FLUME-2054
>
>
> Diffs
> -----
>
>   flume-ng-core/pom.xml 20e975f
>   flume-ng-core/scripts/saveVersion.ps1 PRE-CREATION
>   pom.xml a6992f6
>
> Diff: https://reviews.apache.org/r/11509/diff/
>
>
> Testing
> -------
>
> Verified TestVersionInfo passes on windows
>
>
> Thanks,
>
> Roshan Naik
>
>

+
Brock Noland 2013-05-29, 12:38