Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request 15949: PIG-3565 Make split work with Tez


Copy link to this message
-
Re: Review Request 15949: PIG-3565 Make split work with Tez
Cheolsoo Park 2013-12-03, 03:50

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15949/#review29635
-----------------------------------------------------------
Overall looks good to me.

1. It looks like you've reverted my last-minute changes in PIG-3585 by mistake. Please see my comments below.
2. I see 4 e2e tests fails, and I attached the test logs in the jira.

If you cannot run e2e, we can fix them after committing this.
http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java
<https://reviews.apache.org/r/15949/#comment57043>

    I think you're reverting this by mistake.
    

http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezCompiler.java
<https://reviews.apache.org/r/15949/#comment57044>

    I think you revert this change by mistake.

http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java
<https://reviews.apache.org/r/15949/#comment57050>

    Can you add a TODO with some comment if you're temporarily commenting these out?

http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java
<https://reviews.apache.org/r/15949/#comment57051>

    Can you add a TODO with some comment if you're temporarily commenting these out?
- Cheolsoo Park
On Dec. 3, 2013, 12:18 a.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15949/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 12:18 a.m.)
>
>
> Review request for pig, Alex Bain, Cheolsoo Park, Daniel Dai, and Mark Wagner.
>
>
> Bugs: PIG-3564 and PIG-3565
>     https://issues.apache.org/jira/browse/PIG-3564
>     https://issues.apache.org/jira/browse/PIG-3565
>
>
> Repository: pig
>
>
> Description
> -------
>
>  - POStore and POLocalRearrange are replaced by POStoreTez and POLocalRearrangeTez which have the name of the LogicalOutput. Output is directly written through them and output related code removed from PigProcessor. In the case of combiner, PigCombiner writes through the reduce Context which is routed to LogicalOutput (MRCombiner in Tez handles this).
>  - This patch also contains the security related fixes for PIG-3564. Did not separate it out as I was doing most of the e2e testing with that. Will use PIG-3564 to checkin any incremental changes required after TEZ-606 is fixed.
>
> Still need to handle few cases:
>   - custom partitioner
>   - secondary sort key
>   - memory management (In pig or Tez?) - Was hitting OOM with multiple logical outputs as sort on the split vertex was taking up thrice the amount of memory for 3 logical outputs (OOM in Tez DefaultSorter.java kvbuffer = new byte[maxMemUsage]; )
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/PigServer.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigInputFormat.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POStore.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/CombinerOptimizer.java 1546896
>   http://svn.apache.org/repos/asf/pig/branches/tez/src/org/apache/pig/backend/hadoop/executionengine/tez/POLocalRearrangeTez.java PRE-CREATION