|
|
-
Re: Hadoop code reviews on ReviewBoard?
Eli Collins 2010-10-26, 22:38
On Tue, Oct 26, 2010 at 2:50 PM, Dhruba Borthakur <[EMAIL PROTECTED]> wrote: > I saw an ASF announcement that there's now a review board instance > available, it will be nice if we can try it out.
+1 Thanks Dhruba.
Thanks, Eli
-
Re: Hadoop code reviews on ReviewBoard?
Konstantin Shvachko 2010-11-03, 05:43
It looks very hard to follow. I have really hard time matching jira and review board comments. Especially when they interleave. Why again do we need a second system for tracking issues? --Konstantin On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: > +1 > > On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: > > I saw an ASF announcement that there's now a review board instance >> available, it will be nice if we can try it out. >> >> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the>> >> I filed the following JIRA to see if we can use review board to review >> Hadoop JIRAS. >> >> https://issues.apache.org/jira/browse/INFRA-3108>> >> thanks, >> dhruba >> > >
-
Re: Hadoop code reviews on ReviewBoard?
Eli Collins 2010-11-03, 17:56
Hey Cos, I think the setup used for Hive and HBase posts the RB comments to the jira which makes it easier to follow. RB isn't a second system for tracking issues, jira isn't a code review system, and RB isn't an issue tracker. I think the idea is to have issue/design-level discussion on jira and code-level discussion on RB. Thanks, Eli On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko <[EMAIL PROTECTED]> wrote: > It looks very hard to follow. > I have really hard time matching jira and review board comments. > Especially when they interleave. > Why again do we need a second system for tracking issues? > --Konstantin > > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: > >> +1 >> >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: >> >> I saw an ASF announcement that there's now a review board instance >>> available, it will be nice if we can try it out. >>> >>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the>>> >>> I filed the following JIRA to see if we can use review board to review >>> Hadoop JIRAS. >>> >>> https://issues.apache.org/jira/browse/INFRA-3108>>> >>> thanks, >>> dhruba >>> >> >> >
-
Re: Hadoop code reviews on ReviewBoard?
Konstantin Boudnik 2010-11-03, 18:28
Hey Eli. the explanation is right on the money except that other Konstantin was asking ;) Cos On Wed, Nov 03, 2010 at 10:56AM, Eli Collins wrote: > Hey Cos, > > I think the setup used for Hive and HBase posts the RB comments to the > jira which makes it easier to follow. > > RB isn't a second system for tracking issues, jira isn't a code review > system, and RB isn't an issue tracker. I think the idea is to have > issue/design-level discussion on jira and code-level discussion on RB. > > Thanks, > Eli > > On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko > <[EMAIL PROTECTED]> wrote: > > It looks very hard to follow. > > I have really hard time matching jira and review board comments. > > Especially when they interleave. > > Why again do we need a second system for tracking issues? > > --Konstantin > > > > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote: > > > >> +1 > >> > >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: > >> > >> I saw an ASF announcement that there's now a review board instance > >>> available, it will be nice if we can try it out. > >>> > >>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the> >>> > >>> I filed the following JIRA to see if we can use review board to review > >>> Hadoop JIRAS. > >>> > >>> https://issues.apache.org/jira/browse/INFRA-3108> >>> > >>> thanks, > >>> dhruba > >>> > >> > >> > >
-
Re: Hadoop code reviews on ReviewBoard?
Konstantin Shvachko 2010-11-04, 06:15
> I think the idea is to have issue/design-level discussion on jira and code-level discussion on RB. This is exactly my question. Why do we need two places to have the same discussion? Even if the comments are automatically replicated in jira and/or vice versa. Why not choose one and stick with it? Thanks, --Konst On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <[EMAIL PROTECTED]> wrote: > Hey Cos, > > I think the setup used for Hive and HBase posts the RB comments to the > jira which makes it easier to follow. > > RB isn't a second system for tracking issues, jira isn't a code review > system, and RB isn't an issue tracker. I think the idea is to have > issue/design-level discussion on jira and code-level discussion on RB. > > Thanks, > Eli > > On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko > <[EMAIL PROTECTED]> wrote: > > It looks very hard to follow. > > I have really hard time matching jira and review board comments. > > Especially when they interleave. > > Why again do we need a second system for tracking issues? > > --Konstantin > > > > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> > wrote: > > > >> +1 > >> > >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: > >> > >> I saw an ASF announcement that there's now a review board instance > >>> available, it will be nice if we can try it out. > >>> > >>> > https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the> >>> > >>> I filed the following JIRA to see if we can use review board to review > >>> Hadoop JIRAS. > >>> > >>> https://issues.apache.org/jira/browse/INFRA-3108> >>> > >>> thanks, > >>> dhruba > >>> > >> > >> > > >
-
Re: Hadoop code reviews on ReviewBoard?
Alejandro Abdelnur 2010-11-04, 06:19
Hey Konstantin, have you seen how you can comment on patches and see side by side the changes in RB? It is quite handy. Alejandro On Thu, Nov 4, 2010 at 2:15 PM, Konstantin Shvachko <[EMAIL PROTECTED]>wrote: > > I think the idea is to have issue/design-level discussion on jira and > code-level discussion on RB. > > This is exactly my question. Why do we need two places to have the same > discussion? > Even if the comments are automatically replicated in jira and/or vice > versa. > Why not choose one and stick with it? > > Thanks, > --Konst > > On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <[EMAIL PROTECTED]> wrote: > > > Hey Cos, > > > > I think the setup used for Hive and HBase posts the RB comments to the > > jira which makes it easier to follow. > > > > RB isn't a second system for tracking issues, jira isn't a code review > > system, and RB isn't an issue tracker. I think the idea is to have > > issue/design-level discussion on jira and code-level discussion on RB. > > > > Thanks, > > Eli > > > > On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko > > <[EMAIL PROTECTED]> wrote: > > > It looks very hard to follow. > > > I have really hard time matching jira and review board comments. > > > Especially when they interleave. > > > Why again do we need a second system for tracking issues? > > > --Konstantin > > > > > > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> > > wrote: > > > > > >> +1 > > >> > > >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: > > >> > > >> I saw an ASF announcement that there's now a review board instance > > >>> available, it will be nice if we can try it out. > > >>> > > >>> > > https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the> > >>> > > >>> I filed the following JIRA to see if we can use review board to > review > > >>> Hadoop JIRAS. > > >>> > > >>> https://issues.apache.org/jira/browse/INFRA-3108> > >>> > > >>> thanks, > > >>> dhruba > > >>> > > >> > > >> > > > > > >
-
Re: Hadoop code reviews on ReviewBoard?
Eli Collins 2010-11-04, 06:49
On Wed, Nov 3, 2010 at 11:15 PM, Konstantin Shvachko <[EMAIL PROTECTED]> wrote: > > I think the idea is to have issue/design-level discussion on jira and > code-level discussion on RB. > > This is exactly my question. Why do we need two places to have the same > discussion? > Even if the comments are automatically replicated in jira and/or vice versa. > Why not choose one and stick with it? For a lot of jiras issue level discussion (what's the problem? how should we solve it?) is very different from code level discussion (does this code do what we claim it should? Is it sufficient to be checked in?). Thanks, Eli > > Thanks, > --Konst > > On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <[EMAIL PROTECTED]> wrote: > >> Hey Cos, >> >> I think the setup used for Hive and HBase posts the RB comments to the >> jira which makes it easier to follow. >> >> RB isn't a second system for tracking issues, jira isn't a code review >> system, and RB isn't an issue tracker. I think the idea is to have >> issue/design-level discussion on jira and code-level discussion on RB. >> >> Thanks, >> Eli >> >> On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko >> <[EMAIL PROTECTED]> wrote: >> > It looks very hard to follow. >> > I have really hard time matching jira and review board comments. >> > Especially when they interleave. >> > Why again do we need a second system for tracking issues? >> > --Konstantin >> > >> > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> >> wrote: >> > >> >> +1 >> >> >> >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: >> >> >> >> I saw an ASF announcement that there's now a review board instance >> >>> available, it will be nice if we can try it out. >> >>> >> >>> >> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the>> >>> >> >>> I filed the following JIRA to see if we can use review board to review >> >>> Hadoop JIRAS. >> >>> >> >>> https://issues.apache.org/jira/browse/INFRA-3108>> >>> >> >>> thanks, >> >>> dhruba >> >>> >> >> >> >> >> > >> >
-
Re: Hadoop code reviews on ReviewBoard?
Konstantin Shvachko 2010-11-04, 06:58
Yes, it is pretty handy. It would be really cool to have it integrated with Jira. But having comments in two different places is extremely distracting. Is it only me who finds it hard to match jira messages with RB ones, and duplicating the descriptions, affected versions, etc. in both systems? --Konstantin On Wed, Nov 3, 2010 at 11:19 PM, Alejandro Abdelnur <[EMAIL PROTECTED]>wrote: > Hey Konstantin, > > have you seen how you can comment on patches and see side by side the > changes in RB? > > It is quite handy. > > Alejandro > > On Thu, Nov 4, 2010 at 2:15 PM, Konstantin Shvachko <[EMAIL PROTECTED] > >wrote: > > > > I think the idea is to have issue/design-level discussion on jira and > > code-level discussion on RB. > > > > This is exactly my question. Why do we need two places to have the same > > discussion? > > Even if the comments are automatically replicated in jira and/or vice > > versa. > > Why not choose one and stick with it? > > > > Thanks, > > --Konst > > > > On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <[EMAIL PROTECTED]> wrote: > > > > > Hey Cos, > > > > > > I think the setup used for Hive and HBase posts the RB comments to the > > > jira which makes it easier to follow. > > > > > > RB isn't a second system for tracking issues, jira isn't a code review > > > system, and RB isn't an issue tracker. I think the idea is to have > > > issue/design-level discussion on jira and code-level discussion on RB. > > > > > > Thanks, > > > Eli > > > > > > On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko > > > <[EMAIL PROTECTED]> wrote: > > > > It looks very hard to follow. > > > > I have really hard time matching jira and review board comments. > > > > Especially when they interleave. > > > > Why again do we need a second system for tracking issues? > > > > --Konstantin > > > > > > > > On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> > > > wrote: > > > > > > > >> +1 > > > >> > > > >> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: > > > >> > > > >> I saw an ASF announcement that there's now a review board instance > > > >>> available, it will be nice if we can try it out. > > > >>> > > > >>> > > > > https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the> > > >>> > > > >>> I filed the following JIRA to see if we can use review board to > > review > > > >>> Hadoop JIRAS. > > > >>> > > > >>> https://issues.apache.org/jira/browse/INFRA-3108> > > >>> > > > >>> thanks, > > > >>> dhruba > > > >>> > > > >> > > > >> > > > > > > > > > >
-
Re: Hadoop code reviews on ReviewBoard?
Arun C Murthy 2010-11-04, 07:00
Konst, Todd has volunteered to get RB to send msgs directly to jira, that should help... Arun On Nov 3, 2010, at 11:58 PM, Konstantin Shvachko wrote: > Yes, it is pretty handy. It would be really cool to have it > integrated with > Jira. > But having comments in two different places is extremely distracting. > > Is it only me who finds it hard to match jira messages with RB ones, > and duplicating the descriptions, affected versions, etc. in both > systems? > > --Konstantin > > > On Wed, Nov 3, 2010 at 11:19 PM, Alejandro Abdelnur > <[EMAIL PROTECTED]>wrote: > >> Hey Konstantin, >> >> have you seen how you can comment on patches and see side by side the >> changes in RB? >> >> It is quite handy. >> >> Alejandro >> >> On Thu, Nov 4, 2010 at 2:15 PM, Konstantin Shvachko <[EMAIL PROTECTED] >>> wrote: >> >>>> I think the idea is to have issue/design-level discussion on jira >>>> and >>> code-level discussion on RB. >>> >>> This is exactly my question. Why do we need two places to have the >>> same >>> discussion? >>> Even if the comments are automatically replicated in jira and/or >>> vice >>> versa. >>> Why not choose one and stick with it? >>> >>> Thanks, >>> --Konst >>> >>> On Wed, Nov 3, 2010 at 10:56 AM, Eli Collins <[EMAIL PROTECTED]> >>> wrote: >>> >>>> Hey Cos, >>>> >>>> I think the setup used for Hive and HBase posts the RB comments >>>> to the >>>> jira which makes it easier to follow. >>>> >>>> RB isn't a second system for tracking issues, jira isn't a code >>>> review >>>> system, and RB isn't an issue tracker. I think the idea is to have >>>> issue/design-level discussion on jira and code-level discussion >>>> on RB. >>>> >>>> Thanks, >>>> Eli >>>> >>>> On Tue, Nov 2, 2010 at 10:43 PM, Konstantin Shvachko >>>> <[EMAIL PROTECTED]> wrote: >>>>> It looks very hard to follow. >>>>> I have really hard time matching jira and review board comments. >>>>> Especially when they interleave. >>>>> Why again do we need a second system for tracking issues? >>>>> --Konstantin >>>>> >>>>> On Tue, Oct 26, 2010 at 3:49 PM, Arun C Murthy <[EMAIL PROTECTED]> >>>> wrote: >>>>> >>>>>> +1 >>>>>> >>>>>> On Oct 26, 2010, at 2:50 PM, Dhruba Borthakur wrote: >>>>>> >>>>>> I saw an ASF announcement that there's now a review board >>>>>> instance >>>>>>> available, it will be nice if we can try it out. >>>>>>> >>>>>>> >>>> >> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the>>>>>>> >>>>>>> I filed the following JIRA to see if we can use review board to >>> review >>>>>>> Hadoop JIRAS. >>>>>>> >>>>>>> https://issues.apache.org/jira/browse/INFRA-3108>>>>>>> >>>>>>> thanks, >>>>>>> dhruba >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >>
|
|