-Re: Seeking any DRILL-334 feedback before commit
Jacques Nadeau 2014-01-17, 05:10
Yes, nice catch. I guess GH hadn't updated the force push when I grabbed
the tip. Sorry. To repeat, here is the link:
On Thu, Jan 16, 2014 at 8:50 PM, Jason Altekruse
> Hey Jacques,
> I looked at the parent commit for this to try to figure out what branch of
> yours it was on, the parent of this is listed as the Drill 293 commit that
> was at the tip of master before the last set of merges.
> I found this other commit that is based on the current tip of master, is it
> possible you were trying to upload the changeset from before you rebased
> -Jason Altekruse
> On Thu, Jan 16, 2014 at 8:46 PM, Jacques Nadeau <[EMAIL PROTECTED]>
> > Hey Guys,
> > I've been working on DRILL-334 (Bit RPC socket split) which has also
> > encapsulated enhancing and fixing memory allocation issues. I have a
> > ready that applies cleanly against master. I'm getting errors uploading
> > review board but would like to get some feedback and get this in soon as
> > enforces that all future patches avoid memory leaks of buffers.
> > You can see the (mammoth) changeset on the diff attached to DRILL-334 or
> > you can check it out on my GitHub:
> > Please let me know if you have feedback.
> > Thanks,
> > Jacques