Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 16526: more usage of paths


Copy link to this message
-
Re: Review Request 16526: more usage of paths
Xuefu Zhang 2013-12-31, 06:40

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16526/#review30995
-----------------------------------------------------------

trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java
<https://reviews.apache.org/r/16526/#comment59314>

    There might be an tab/indention problem.

trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/MergeWork.java
<https://reviews.apache.org/r/16526/#comment59316>

    Is it safer to do path.toUri().toString()? I saw it's done this way in other part of changes.

trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java
<https://reviews.apache.org/r/16526/#comment59319>

    Same as above.

trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java
<https://reviews.apache.org/r/16526/#comment59320>

    Same as above.

trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java
<https://reviews.apache.org/r/16526/#comment59341>

    Could you confirm that tmpDir isn't used? The old code seemed spending quite some effort generating the temp directory.
- Xuefu Zhang
On Dec. 31, 2013, 12:42 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16526/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2013, 12:42 a.m.)
>
>
> Review request for hive, Xuefu Zhang and Xuefu Zhang.
>
>
> Bugs: HIVE-6121
>     https://issues.apache.org/jira/browse/HIVE-6121
>
>
> Repository: hive
>
>
> Description
> -------
>
> Refactoring patch.
>
>
> Diffs
> -----
>
>   trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554326
>   trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatMultiOutputFormat.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/BlockMergeTask.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/MergeWork.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanWork.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateMapper.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateTask.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/truncate/ColumnTruncateWork.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRFileSink1.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/AlterTablePartMergeFilesDesc.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 1554326
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 1554326