Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop >> mail # dev >> Re: Review Request: SQOOP-726 Put debugging information into generated SqoopRecord class


Copy link to this message
-
Re: Review Request: SQOOP-726 Put debugging information into generated SqoopRecord class

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8234/#review13926
-----------------------------------------------------------

Ship it!
LGTM. I will commit it after running unit test.

- Cheolsoo Park
On Nov. 27, 2012, 3:46 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8234/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 3:46 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've add proposed two fields as a comment entries into generated class.
>
>
> This addresses bug SQOOP-726.
>     https://issues.apache.org/jira/browse/SQOOP-726
>
>
> Diffs
> -----
>
>   src/java/org/apache/sqoop/orm/ClassWriter.java f456e9922b46cf45cfa66e8bb1049114c06de55e
>
> Diff: https://reviews.apache.org/r/8234/diff/
>
>
> Testing
> -------
>
> Tests are passing and I've checked change on real life cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>