Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


Copy link to this message
-
Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures


> On July 21, 2013, 4:38 p.m., Jarek Cecho wrote:
> > core/src/main/java/org/apache/sqoop/framework/JobManager.java, line 265
> > <https://reviews.apache.org/r/12713/diff/2/?file=323241#file323241line265>
> >
> >     I do have concern that adding new parameter each time we will need to add new information that will be propagated from client won't scale much. What about introducing something like ConnectionContext or HttpContext that will for start contain the username and in the future all additional details?

Thank you, Jarcec. This is really a good one. I will definitely think about this.
- Mengwei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review23595
-----------------------------------------------------------
On July 18, 2013, 5:09 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 5:09 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d1cca7f5283847096dec27134edf56804f07e96d
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jul 17 10:48:05 2013 -0700
>
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
>
> :100644 100644 b7b0436... a7a748b... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32bca71... 13b2475... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 590e4e7... 70111e3... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 cbc956d... a7343d4... M client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 5537a8e... 5f077ea... M client/src/main/resources/client-resource.properties
> :100644 100644 b4e986a... c452662... M common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 a830646... fddeb06... M common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 6efc8a0... M common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 98768d6... ed604de... M common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 137e71c... 7db8d98... M common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 dd1d75b... 49cb300... M common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... bfcaffa... M common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 4ea42b1... 7d96468... M common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 9f09982... c267b7b... M core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :100644 100644 f717abf... 9ba67d2... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 68cb1c0... 413c188... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b2cd6cc... 99dc3b1... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 038f602... 456cbb8... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 ab3f9d0... d82ad08... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 73a01e1... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
>
>
> Diffs
> -----
>
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java b7b0436