Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo >> mail # dev >> Indentation style?

Copy link to this message
Re: Indentation style?
+1 for two-spaces no tabs! It's the style used by all of the Hadoop
ecosystem projects that I've seen so far, so if you hope to share
developers with them, there's some value in consistency.

Large-scale reformatting is awful in an existing project with a long
svn history since it breaks svn blame, etc. But since this was a new
svn import, now is the best (only) time to consider doing one :)


On Wed, Oct 12, 2011 at 7:28 PM, Jesse Yates <[EMAIL PROTECTED]> wrote:
> +1 with doing a large scale formatting.
> I think it is important that we just pick one style and make sure it is
> unique across the codebase, more than exactly what it is (though like every
> developer I have my preferences :)
> I generally also like to use the same kind of formatting Drew is
> recommending. I tend to use HBase's formatting, which is pretty close to
> what Drew already mentioned.
> Also, if there is a current standard (or if we create one), it needs to be
> added to a FAQ (or equivalent) section of the website.
> -Jesse Yates
> On Wed, Oct 12, 2011 at 6:46 PM, Drew Farris <[EMAIL PROTECTED]> wrote:
>> Hi All,
>> I'm wondering if there's consensus on the indentation style for Accumulo?
>> In the code and poms, I'm seeing cases where tabs are used, where
>> spaces are used, where each is used interchangeably, sometimes mixed
>> in the same file. This makes things difficult to read in some cases.
>> I'm used to the Lucene style, spaces instead of tabs, with two space
>> indents, as embodied in
>> http://people.apache.org/~rmuir/Eclipse-Lucene-Codestyle.xml
>> Are there styles others prefer?
>> I also want to say upfront that I'm not suggesting a large scale code
>> reformatting to get everything to adhere to any one style at once. I'm
>> simply curious whether there is a style contributors should adhere to
>> going forward, with indentation being fixed as needed along with other
>> changes.
>> Drew

Todd Lipcon
Software Engineer, Cloudera