Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)


Copy link to this message
-
Re: Review Request: Column stats : LOW_VALUE (or HIGH_VALUE) will always be 0.0000 , if all the column values larger than 0.0 (or if all column values smaller than 0.0)
Ashutosh Chauhan 2013-06-01, 21:57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11172/#review21293
-----------------------------------------------------------
Request for comments.
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/11172/#comment44172>

    Can you add a comment about why we need to set it MAX value instead of 0, since its not apparent?

http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/11172/#comment44173>

    Similarly can you add a comment why we need to set max to -ve infinity and not 0, since its counter intuitive?
- Ashutosh Chauhan
On May 15, 2013, 7:11 a.m., Zhuoluo Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11172/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 7:11 a.m.)
>
>
> Review request for hive, Carl Steinbach, Carl Steinbach, and fangkun cao.
>
>
> Description
> -------
>
> An initialization error.
> Make double and long initialize correctly.
> Would you review that and assign the issue to me?
>
>
> This addresses bug HIVE-4561.
>     https://issues.apache.org/jira/browse/HIVE-4561
>
>
> Diffs
> -----
>
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 1482697
>
> Diff: https://reviews.apache.org/r/11172/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhuoluo Yang
>
>