Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Re: Review Request: HIVE-3004: RegexSerDe should support other column types in addition to STRING


Copy link to this message
-
Re: Review Request: HIVE-3004: RegexSerDe should support other column types in addition to STRING
Ashutosh Chauhan 2013-01-13, 20:15

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8931/#review15305
-----------------------------------------------------------

serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java
<https://reviews.apache.org/r/8931/#comment32972>

    Are we sure that reference equality here is guaranteed to work? In other words, we don't need .equals() instead?
    Same question for all == comparisons on subsequent line as well.
- Ashutosh Chauhan
On Jan. 12, 2013, 12:28 a.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8931/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2013, 12:28 a.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Description
> -------
>
> This patch enhances regex serde to parse column types other than STRING. Only primitive types are supported.
>
>
> This addresses bug HIVE-3004.
>     https://issues.apache.org/jira/browse/HIVE-3004
>
>
> Diffs
> -----
>
>   ql/src/test/queries/clientnegative/serde_regex.q 6603b91
>   ql/src/test/queries/clientpositive/serde_regex.q c6809cb
>   ql/src/test/results/clientnegative/serde_regex.q.out 03fe907
>   ql/src/test/results/clientpositive/serde_regex.q.out a8ce604
>   serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java e728244
>
> Diff: https://reviews.apache.org/r/8931/diff/
>
>
> Testing
> -------
>
> New test cases have been added and they pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>