Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1777: AbstractSource does not provide enough implementation for sub-classes


Copy link to this message
-
Review Request: FLUME-1777: AbstractSource does not provide enough implementation for sub-classes
Brock Noland 2012-12-12, 21:17

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8558/
-----------------------------------------------------------

Review request for Flume.
Description
-------

Adds BasicSourceSemantics (named similar to the Channel abstract classes) which sets the life cycle state appropriate, doesn't require the use of super, and allows subclasses to set the lifecycle state. Additionall adds AbstractPollableSource and AbstractEventDrivenSource.
This addresses bug FLUME-1777.
    https://issues.apache.org/jira/browse/FLUME-1777
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/source/AbstractEventDrivenSource.java PRE-CREATION
  flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java PRE-CREATION
  flume-ng-core/src/main/java/org/apache/flume/source/BasicSourceSemantics.java PRE-CREATION
  flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java d4d818a
  flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java PRE-CREATION
  flume-ng-core/src/test/java/org/apache/flume/source/TestBasicSourceSemantics.java PRE-CREATION

Diff: https://reviews.apache.org/r/8558/diff/
Testing
-------

Unit tests added, pass.
Thanks,

Brock Noland