Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: SQOOP-576: Implement command "show framework" end to end


Copy link to this message
-
Review Request: SQOOP-576: Implement command "show framework" end to end
Jarek Cecho 2012-08-23, 07:08

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6745/
-----------------------------------------------------------

Review request for Sqoop and Bilung Lee.
Description
-------

I've implemented show framework command from end to end.
This addresses bug SQOOP-576.
    https://issues.apache.org/jira/browse/SQOOP-576
Diffs
-----

  /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/display/FormDisplayer.java PRE-CREATION
  /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/request/FrameworkRequest.java PRE-CREATION
  /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java 1376378
  /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java 1376378
  /branches/sqoop2/client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java PRE-CREATION
  /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 1376378
  /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/FrameworkBean.java PRE-CREATION
  /branches/sqoop2/common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java PRE-CREATION
  /branches/sqoop2/common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java PRE-CREATION
  /branches/sqoop2/core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 1376378
  /branches/sqoop2/server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java PRE-CREATION
  /branches/sqoop2/server/src/main/java/org/apache/sqoop/server/v1/FrameworkServlet.java PRE-CREATION
  /branches/sqoop2/server/src/main/webapp/WEB-INF/web.xml 1376378

Diff: https://reviews.apache.org/r/6745/diff/
Testing
-------

- I've done manual testing (trying command "show framework" in client).
- Some minor unit tests are included
Thanks,

Jarek Cecho

+
Bilung Lee 2012-08-27, 17:19