Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase >> mail # dev >> HBASE Code format


Copy link to this message
-
Re: HBASE Code format
Please no codebase-wide reformat. It makes moving patches between
versions a huge pain in the butt, and loses blame data like Harsh
said.

I find 120 characters too wide - on my laptop screen I can't
reasonable fit two windows of code side by side if they're that wide.
100's about as much as I can fit (and I use a tiny font, too!)

-Todd

On Thu, Mar 22, 2012 at 12:15 PM, Harsh J <[EMAIL PROTECTED]> wrote:
> On Fri, Mar 23, 2012 at 12:40 AM, Stack <[EMAIL PROTECTED]> wrote:
>> On Wed, Mar 21, 2012 at 10:17 PM, Laxman <[EMAIL PROTECTED]> wrote:
>>> Note: We don't need to reformat entire codebase. My proposal is to apply
>>> these standards to new code getting commited.
>
> I think if it is to change, it should entirely change than appear
> inconsistent (and hence, 'ugly'). I understand the only concern here
> would be loss of valuable "git blame" form of data? There may be
> tricks to avoid that though (user or server side).
>
> --
> Harsh J

--
Todd Lipcon
Software Engineer, Cloudera
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB