Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase, mail # dev - Are we no longer giving credit in SVN commit messages?


Copy link to this message
-
Re: Are we no longer giving credit in SVN commit messages?
Jonathan Hsieh 2014-01-21, 01:05
Of the last 1000 commits, only 71 had '.' and 41 had ':'.  The other 888
were "naked".  Honestly, not a big deal (I usually sed these extra things
out when I run scripts on the gitlog).

jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep \\. | wc
     71      71     938
jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep \\: | wc
     41      41     499

jon@swoop:~/proj/hbase$ git log --oneline apache/trunk | awk '{print $2}' |
grep HBASE | head -1000 | grep -v \\: | grep -v \\. | wc
    888     888   10011

On Mon, Jan 20, 2014 at 4:47 PM, Andrew Purtell <[EMAIL PROTECTED]> wrote:

> Oh, we don't want the "."? It's pretty universal in Hadoop land (just
> checked common, hdfs, mapreduce, yarn, and zookeeper).
>
>
> On Mon, Jan 20, 2014 at 4:46 PM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:
>
> > +1 to andrews format
> >
> > HBASE-xxxxx JIRA Title (contributor name)
> >
> > One nit is most of our jiras are committed without the '.' after the jira
> > name.  Not the end of the world if a '.' or ':' sneaks in.
> >
> > Jon
> >
> >
> > On Mon, Jan 20, 2014 at 4:36 PM, Andrew Purtell <[EMAIL PROTECTED]>
> > wrote:
> >
> > > I see some committers are continuing the informal practice we've had of
> > > attribution in parenthesis after the issue description if the work is
> not
> > > your own, e.g.
> > >
> > > HBASE-XXXX. JIRA title goes here (Contributor Name)
> > >
> > > I've noticed that some committers are definitely not doing this.
> > >
> > > I think it is bad practice not to provide attribution to the
> contributor
> > in
> > > the commit message. When one is reviewing commit history, neither links
> > to
> > > JIRA nor inlining of JIRA content is possible -- unless there is some
> > tool
> > > that does this of which I'm not aware (please let me know!).
> > >
> > > --
> > > Best regards,
> > >
> > >    - Andy
> > >
> > > Problems worthy of attack prove their worth by hitting back. - Piet
> Hein
> > > (via Tom White)
> > >
> >
> >
> >
> > --
> > // Jonathan Hsieh (shay)
> > // Software Engineer, Cloudera
> > // [EMAIL PROTECTED]
> >
>
>
>
> --
> Best regards,
>
>    - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>

--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// [EMAIL PROTECTED]