I have this functionality in our internal branch.
I can post the patch but it is likely to conflict with ZOOKEEPER-1346, so
it will be good to know the timeline of that patch.
On 7/8/13 11:48 AM, "Sergey Maslyakov" <[EMAIL PROTECTED]> wrote:
>I think I'd answer my own question. Apparently, if lastZxid does not
>between two takeSnapshot() calls, they both will try to write into the
>file. This is likely to explode when you try to read this snapshot back...
>So, the protection is needed.
>On Mon, Jul 8, 2013 at 12:03 PM, Sergey Maslyakov <[EMAIL PROTECTED]>
>> From looking at the 3.4.5 code, it seems like
>> ZooKeeperServer.takeSnapshot() method does not have protection against
>> being invoked twice by different threads. There is some protection
>> spawning two snapshot threads from SyncRequestProcessor.run() but this
>> just about it.
>> Is there any inherent danger in having two
>> overlapping their execution in time? Is it a thread to data integrity
>> it just a possible performance issue?
>> I'm thinking of adding a new four-letter command to force a snapshot
>> creation by a command from outside before snapCount threshold is
>> Is it safe to invoke ZooKeeperServer.takeSnapshot() from a four-word
>> command handler or does it need to be submitted as a Request object into
>> the pipeline of Request Processors?