Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Sqoop, mail # dev - Review Request: Securing passwords in sqoop 1.x


+
Seetharam Venkatesh 2013-03-06, 07:23
+
Seetharam Venkatesh 2013-03-06, 07:24
+
Jarek Cecho 2013-03-10, 00:18
+
Seetharam Venkatesh 2013-03-10, 07:02
+
Jarek Cecho 2013-03-10, 20:41
+
Seetharam Venkatesh 2013-03-11, 07:00
+
Jarek Cecho 2013-03-12, 04:30
+
Seetharam Venkatesh 2013-03-13, 21:41
+
Seetharam Venkatesh 2013-03-13, 21:41
Copy link to this message
-
Re: Review Request: Securing passwords in sqoop 1.x
Jarek Cecho 2013-03-14, 04:30

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9771/#review17850
-----------------------------------------------------------
Hi Venkatesh,
thank you for updating the patch. I have just two small nits. I'll take a few days to see if I'll be able to think of a way to crack it. I'll go ahead and commit it in case that I won't find any issues.

src/docs/user/connecting.txt
<https://reviews.apache.org/r/9771/#comment37809>

    Technically speaking the parameter -P is the most secure way of entering password, right? It's not stored anywhere and thus it can't leak in any way.

src/java/org/apache/sqoop/SqoopOptions.java
<https://reviews.apache.org/r/9771/#comment37810>

    Can we put "return" after this statement?
Jarcec

- Jarek Cecho
On March 13, 2013, 9:41 p.m., Seetharam Venkatesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9771/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 9:41 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> An attempt to add a way for users to pass credentials to sqoop in a secure way by storing the password in a file under user's home directory with 400 permissions.
>
>
> This addresses bug https://issues.apache.org/jira/browse/SQOOP-914.
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-914
>
>
> Diffs
> -----
>
>   src/docs/man/common-args.txt cf9c0c3
>   src/docs/user/common-args.txt 0554f81
>   src/docs/user/connecting.txt 44a5111
>   src/docs/user/help.txt 24fbddc
>   src/docs/user/tools.txt 96bf777
>   src/java/org/apache/sqoop/SqoopOptions.java addc889
>   src/java/org/apache/sqoop/mapreduce/db/DBConfiguration.java d270bc8
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 684d4a5
>   src/java/org/apache/sqoop/util/CredentialsUtil.java PRE-CREATION
>   src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9771/diff/
>
>
> Testing
> -------
>
> Adds unit tests. All unit tests pass and checkstyle issues fixed.
>
>
> Thanks,
>
> Seetharam Venkatesh
>
>

+
Seetharam Venkatesh 2013-03-14, 08:24
+
Jarek Cecho 2013-03-17, 19:37
+
Seetharam Venkatesh 2013-03-19, 08:30
+
Jarek Cecho 2013-03-20, 19:21