Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.


Copy link to this message
-
Re: Review Request: FLUME-1772: AbstractConfigurationProvider should remove component which throws exception from configure method.
Brock Noland 2012-12-19, 01:15


> On Dec. 19, 2012, 1:15 a.m., Brock Noland wrote:
> > flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java, line 114
> > <https://reviews.apache.org/r/8421/diff/3/?file=240770#file240770line114>
> >
> >     Good catch!

I'll update this patch tomorrow as I am testing another patch.
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8421/#review14705
-----------------------------------------------------------
On Dec. 18, 2012, 9:11 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8421/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2012, 9:11 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Catches Exception around all the configure() methods of components. If they throw an exception, they are removed from the configuration (not added).
>
>
> This addresses bug FLUME-1772.
>     https://issues.apache.org/jira/browse/FLUME-1772
>
>
> Diffs
> -----
>
>   flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java daef76b
>   flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java 25001b1
>
> Diff: https://reviews.apache.org/r/8421/diff/
>
>
> Testing
> -------
>
> Tests added for source, channel, and sink.
>
>
> Thanks,
>
> Brock Noland
>
>