Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive >> mail # dev >> Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults


Copy link to this message
-
Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults


> On Dec. 6, 2013, 3:13 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 457
> > <https://reviews.apache.org/r/16063/diff/1/?file=394724#file394724line457>
> >
> >     I think it will be better to say soemthing like "Concurrency level " + resultSetConcurrency + " not supported "
> >    
> >

Updated the error message
> On Dec. 6, 2013, 3:13 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java, line 460
> > <https://reviews.apache.org/r/16063/diff/1/?file=394724#file394724line460>
> >
> >     can you include the unsupported type in error message ?

Updated the error message.
> On Dec. 6, 2013, 3:13 a.m., Thejas Nair wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1581
> > <https://reviews.apache.org/r/16063/diff/1/?file=394728#file394728line1581>
> >
> >     should we just fail in the unlikely event the clearFetch throws an exception ? It might be in some weird state if this happens.
> >     But I don't have strong opinions about it.
> >

hmm .. I think that's would be a safer approach. It might be very tricky to diagnose subsequent errors if any.
Changed it to throw an exception.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16063/#review29866
-----------------------------------------------------------
On Dec. 6, 2013, 12:31 a.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16063/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2013, 12:31 a.m.)
>
>
> Review request for hive and Brock Noland.
>
>
> Bugs: HIVE-4395
>     https://issues.apache.org/jira/browse/HIVE-4395
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Support fetch-from-start for hiveserver2 fetch operations.
>  - Handle new fetch orientation for various HS2 operations.
>  - Added support to reset the read position in Hive driver
>  - Enabled scroll cursors with support for positioning cursor to start of resultset
>
>
> Diffs
> -----
>
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 812ee56
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java ed502a7
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 86db406
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 343f760
>   ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java ce54e0c
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 581e69c
>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java af87a90
>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 0fe01c0
>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java bafe40c
>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java 2be018e
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 7e8a06b
>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2daa9cd
>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java a1ac55b
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 301187d
>
> Diff: https://reviews.apache.org/r/16063/diff/
>
>
> Testing
> -------
>
> Added new testcases to TestJdbcDriver2
>
>
> Thanks,
>
> Prasad Mujumdar
>
>