Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request 14569: Patch for FLUME-2120


Copy link to this message
-
Re: Review Request 14569: Patch for FLUME-2120
Jeff jlord 2013-10-14, 15:26

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14569/#review26972
-----------------------------------------------------------
Venkatesh,

I just added a test for the tcp syslog source in FLUME-1666
Can you rebase against trunk and add a source counter test there?

Thank You,

Jeff

- Jeff jlord
On Oct. 10, 2013, 3:23 a.m., Venkatesh Sivasubramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14569/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2013, 3:23 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: Flume-2120
>     https://issues.apache.org/jira/browse/Flume-2120
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Pls. find the patch attached for the FLUME-2120.
>
> I have made changes to SyslogUDPSource and SyslogTCPSource. Tested it locally and also have added a JUnit for SyslogUDPSource.
> I see the MultiportSyslogTCPSource is pretty much a better version/likely replacement for SyslogTCPSource. But still went ahead and added the metrics counters to SyslogTCPSource, as the change was straight forward and its very much a part of the code base.
>
>
> Diffs
> -----
>
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java db9e0fd
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 96a9e85
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java 2d7a429
>
> Diff: https://reviews.apache.org/r/14569/diff/
>
>
> Testing
> -------
>
> JUnit added for SyslogUDPSource.
>
>
> Thanks,
>
> Venkatesh Sivasubramanian
>
>