Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume, mail # dev - Review Request: FLUME-1898. Thrift Source


+
Hari Shreedharan 2013-02-07, 03:38
+
Brock Noland 2013-02-07, 15:23
+
Hari Shreedharan 2013-02-07, 22:04
+
Hari Shreedharan 2013-02-07, 22:03
+
Hari Shreedharan 2013-02-07, 22:47
+
Hari Shreedharan 2013-02-08, 09:36
Copy link to this message
-
Re: Review Request: FLUME-1898. Thrift Source
Brock Noland 2013-02-10, 21:04

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9352/#review16398
-----------------------------------------------------------
Looks great! A few comments below. Also, does this have to be added to the dist pom? I know I have had trouble with things like the JMS source because I didn't add it to the n requisite places.
flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34882>

    I don't see a formatting place for this string. Not sur what log4j will do with the second string passed as an arg.

flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34884>

    Do we want to log the exception or exception message here?

flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java
<https://reviews.apache.org/r/9352/#comment34883>

    Does log4j accept string formatting? Typically I see {} being used.

flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java
<https://reviews.apache.org/r/9352/#comment34885>

    This is a more reliable mechanism to find a free port:
    
    ServerSocket socket = new ServerSocket(0);
    int port = socket.getLocalPort();
    socket.close();
- Brock Noland
On Feb. 8, 2013, 9:36 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9352/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2013, 9:36 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Thrift Source.
>
>
> This addresses bug FLUME-1898.
>     https://issues.apache.org/jira/browse/FLUME-1898
>
>
> Diffs
> -----
>
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 3312b04
>   flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 058ca1c
>   flume-ng-core/pom.xml 7db4f23
>   flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java PRE-CREATION
>   flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9352/diff/
>
>
> Testing
> -------
>
> Added several unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>

+
Hari Shreedharan 2013-02-10, 22:48
+
Hari Shreedharan 2013-02-10, 22:50
+
Brock Noland 2013-02-11, 16:15
+
Hari Shreedharan 2013-02-11, 17:44
+
Brock Noland 2013-02-11, 18:54