Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used


Copy link to this message
-
Re: Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13273/#review25511
-----------------------------------------------------------
Hi Mengwei,
thank you for rebasing the patch and adding the additional features.
shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
<https://reviews.apache.org/r/13273/#comment49960>

    The help text displaying is not currently ideal and we already do have couple of JIRAs solving it - for example SQOOP-965 or SQOOP-819.
    
    As this code change would make one command behave differently then the others, can we solve the original problem of the JIRA and let the help text be solved by the other JIRAs?
Jarcec

- Jarek Cecho
On Aug. 19, 2013, 9:17 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13273/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 9:17 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1162
>     https://issues.apache.org/jira/browse/SQOOP-1162
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit 894e2fe8b01cd1d12f4f8e9377a60707a22faf04
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Mon Aug 5 10:47:29 2013 -0700
>
>     SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used
>
> :100644 100644 672fa85... 0520bfa... M shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
> :100644 100644 5e3c3ff... 6c8cb0f... M shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java
> :100644 100644 475f41c... f7d02e5... M shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 df9457d... fd268b0... M shell/src/main/resources/shell-resource.properties
>
>
> Diffs
> -----
>
>   shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java 672fa85
>   shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java 5e3c3ff
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 475f41c
>   shell/src/main/resources/shell-resource.properties df9457d
>
> Diff: https://reviews.apache.org/r/13273/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>