Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687 to track this.

On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:

> How about adding this step to the MR PreCommit jenkins job so it's run
> as part test-patch?
>
> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <[EMAIL PROTECTED]> wrote:
>> Committers,
>>
>> As most people are aware, the MapReduce 'classic' tests (in hadoop-mapreduce-project/src/test) still need to built using ant since they aren't mavenized yet.
>>
>> I've seen several commits (and 2 within the last hour i.e. MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe developers/committers aren't checking for this.
>>
>> Henceforth, with all changes, before committing, please do run:
>> $ mvn install
>> $ cd hadoop-mapreduce-project
>> $ ant veryclean all-jars -Dresolvers=internal
>>
>> These instructions were already in http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've just updated http://wiki.apache.org/hadoop/HowToContribute.
>>
>> thanks,
>> Arun
>>

--
Arun C. Murthy
Hortonworks Inc.
http://hortonworks.com/

As per my comment on the bug.  I though we were going to remove them.

MAPREDUCE-4266 only needs a little bit more work, change a patch to a
script, before they disappear entirely.  I would much rather see dead code
die then be maintained for a few tests that are mostly testing the dead
code itself.
--Bobby

On 9/26/12 9:39 AM, "Arun C Murthy" <[EMAIL PROTECTED]> wrote:

>Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687
>to track this.
>
>On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:
>
>> How about adding this step to the MR PreCommit jenkins job so it's run
>> as part test-patch?
>>
>> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <[EMAIL PROTECTED]>
>>wrote:
>>> Committers,
>>>
>>> As most people are aware, the MapReduce 'classic' tests (in
>>>hadoop-mapreduce-project/src/test) still need to built using ant since
>>>they aren't mavenized yet.
>>>
>>> I've seen several commits (and 2 within the last hour i.e.
>>>MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe
>>>developers/committers aren't checking for this.
>>>
>>> Henceforth, with all changes, before committing, please do run:
>>> $ mvn install
>>> $ cd hadoop-mapreduce-project
>>> $ ant veryclean all-jars -Dresolvers=internal
>>>
>>> These instructions were already in
>>>http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've
>>>just updated http://wiki.apache.org/hadoop/HowToContribute.
>>>
>>> thanks,
>>> Arun
>>>
>
>--
>Arun C. Murthy
>Hortonworks Inc.
>http://hortonworks.com/
>
>

That is fine, we may want to then mark it so that the MR-4687 depends on the JIRA to port the tests, so the tests don't disapear before we are done.

--Bobby

From: Arun C Murthy <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>
Date: Wednesday, September 26, 2012 12:31 PM
To: "[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>" <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>, "Yahoo! Inc." <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>
Cc: "[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>" <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>, "[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>" <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>, "[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>" <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>
Subject: Re: Commits breaking compilation of MR 'classic' tests

Fair, however there are still tests which need to be ported over. We can remove them after the port.

On Sep 26, 2012, at 9:54 AM, Robert Evans wrote:

As per my comment on the bug.  I though we were going to remove them.

MAPREDUCE-4266 only needs a little bit more work, change a patch to a
script, before they disappear entirely.  I would much rather see dead code
die then be maintained for a few tests that are mostly testing the dead
code itself.
--Bobby

On 9/26/12 9:39 AM, "Arun C Murthy" <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>> wrote:

Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687
to track this.

On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:

How about adding this step to the MR PreCommit jenkins job so it's run
as part test-patch?

On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <[EMAIL PROTECTED]<mailto:[EMAIL PROTECTED]>>
wrote:
Committers,

As most people are aware, the MapReduce 'classic' tests (in
hadoop-mapreduce-project/src/test) still need to built using ant since
they aren't mavenized yet.

I've seen several commits (and 2 within the last hour i.e.
MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe
developers/committers aren't checking for this.

Henceforth, with all changes, before committing, please do run:
$ mvn install
$ cd hadoop-mapreduce-project
$ ant veryclean all-jars -Dresolvers=internal

These instructions were already in
http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've
just updated http://wiki.apache.org/hadoop/HowToContribute.

thanks,
Arun
--
Arun C. Murthy
Hortonworks Inc.
http://hortonworks.com/
--
Arun C. Murthy
Hortonworks Inc.
http://hortonworks.com/

So is someone signing up to do this port soon?  Otherwise I don't see the
point in us spending time keeping tests that mostly don't apply working. I
used to spend a lot of time on this when we still had to compile contrib
stuff out of ant and the majority of it was just fixing it so it compiles
again with no benefit to the mrv2 stuff.

I would be more in favor of removing it now and when someone goes to port
the tests they can always get them out of svn.

Tom

On 9/26/12 12:31 PM, "Arun C Murthy" <[EMAIL PROTECTED]> wrote:

>Fair, however there are still tests which need to be ported over. We can
>remove them after the port.
>
>On Sep 26, 2012, at 9:54 AM, Robert Evans wrote:
>
>> As per my comment on the bug.  I though we were going to remove them.
>>
>> MAPREDUCE-4266 only needs a little bit more work, change a patch to a
>> script, before they disappear entirely.  I would much rather see dead
>>code
>> die then be maintained for a few tests that are mostly testing the dead
>> code itself.
>>
>>
>> --Bobby
>>
>> On 9/26/12 9:39 AM, "Arun C Murthy" <[EMAIL PROTECTED]> wrote:
>>
>>> Point. I've opened https://issues.apache.org/jira/browse/MAPREDUCE-4687
>>> to track this.
>>>
>>> On Sep 25, 2012, at 9:33 PM, Eli Collins wrote:
>>>
>>>> How about adding this step to the MR PreCommit jenkins job so it's run
>>>> as part test-patch?
>>>>
>>>> On Tue, Sep 25, 2012 at 7:48 PM, Arun C Murthy <[EMAIL PROTECTED]>
>>>> wrote:
>>>>> Committers,
>>>>>
>>>>> As most people are aware, the MapReduce 'classic' tests (in
>>>>> hadoop-mapreduce-project/src/test) still need to built using ant
>>>>>since
>>>>> they aren't mavenized yet.
>>>>>
>>>>> I've seen several commits (and 2 within the last hour i.e.
>>>>> MAPREDUCE-3681 and MAPREDUCE-3682) which lead me to believe
>>>>> developers/committers aren't checking for this.
>>>>>
>>>>> Henceforth, with all changes, before committing, please do run:
>>>>> $ mvn install
>>>>> $ cd hadoop-mapreduce-project
>>>>> $ ant veryclean all-jars -Dresolvers=internal
>>>>>
>>>>> These instructions were already in
>>>>> http://wiki.apache.org/hadoop/HowToReleasePostMavenization and I've
>>>>> just updated http://wiki.apache.org/hadoop/HowToContribute.
>>>>>
>>>>> thanks,
>>>>> Arun
>>>>>
>>>
>>> --
>>> Arun C. Murthy
>>> Hortonworks Inc.
>>> http://hortonworks.com/
>>>
>>>
>>
>
>--
>Arun C. Murthy
>Hortonworks Inc.
>http://hortonworks.com/
>
>