Home | About | Sematext search-lucene.com search-hadoop.com
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB
 Search Hadoop and all its subprojects:

Switch to Plain View
Hadoop >> mail # dev >> trailing whitespace


+
Radim Kolar 2012-11-25, 19:14
Copy link to this message
-
Re: trailing whitespace
On Sun, Nov 25, 2012 at 11:14 AM, Radim Kolar <[EMAIL PROTECTED]> wrote:

> I propose addition to QA bot - check for trailing whitespace in patches.
> Probably checking for tabs in Java files would be also good idea.
>
>
Checking for tabs I could get behind; checking for trailing whitespace not
so much.

I've never understood why folks get worked up over a little trailing
whitespace here and there, since you can't see it and it doesn't affect
correctness. Spurious whitespace changes that make a review harder - those
are annoying. Trailing whitespace inadvertently left on lines where
legitimate changes were made in a patch - doesn't seem too harmful to me.

--
Aaron T. Myers
Software Engineer, Cloudera
+
Radim Kolar 2012-11-26, 18:53
+
Aaron T. Myers 2012-11-26, 23:53
+
Colin McCabe 2012-11-26, 18:00
+
Harsh J 2012-11-25, 19:35
NEW: Monitor These Apps!
elasticsearch, apache solr, apache hbase, hadoop, redis, casssandra, amazon cloudwatch, mysql, memcached, apache kafka, apache zookeeper, apache storm, ubuntu, centOS, red hat, debian, puppet labs, java, senseiDB