Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender


+
Cameron Gandevia 2012-12-03, 20:52
+
Hari Shreedharan 2012-12-04, 04:40
+
Cameron Gandevia 2012-12-07, 20:12
+
Hari Shreedharan 2012-12-10, 19:45
+
Brock Noland 2012-12-21, 18:02
+
Hari Shreedharan 2012-12-22, 22:54
+
Hari Shreedharan 2013-01-03, 23:44
+
Hari Shreedharan 2013-01-04, 02:53
+
Cameron Gandevia 2013-01-18, 02:29
+
Hari Shreedharan 2013-01-22, 06:03
+
Cameron Gandevia 2013-01-18, 02:17
+
Hari Shreedharan 2013-01-22, 06:07
Copy link to this message
-
Re: Review Request: FLUME-1765 - Add Load Balancing Support to Log4jAppender

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8328/#review15566
-----------------------------------------------------------
+1. Looks good. Please remove the extra file, and the whitespaces and submit the patch on the jira. Also remove the System.out.println calls too. A
flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java
<https://reviews.apache.org/r/8328/#comment33647>

    Please remove these Stdout calls.

flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java
<https://reviews.apache.org/r/8328/#comment33648>

    Please remove this stdout call.
- Hari Shreedharan
On Jan. 18, 2013, 2:17 a.m., Cameron Gandevia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8328/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 2:17 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> The Log4jAppender should be extended to use the LoadBalancingRpcClient allowing users to configure a load balancing log4jappender
>
>
> Diffs
> -----
>
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/LoadBalancingLog4jAppender.java PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java 315a68c
>   flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java.orig PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-backoff-log4jtest.properties PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancing-rnd-log4jtest.properties PRE-CREATION
>   flume-ng-clients/flume-ng-log4jappender/src/test/resources/flume-loadbalancinglog4jtest.properties PRE-CREATION
>   flume-ng-doc/sphinx/FlumeUserGuide.rst aa92974
>
> Diff: https://reviews.apache.org/r/8328/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Cameron Gandevia
>
>

+
Cameron Gandevia 2013-01-22, 22:09
+
Cameron Gandevia 2013-02-21, 22:43
+
Hari Shreedharan 2013-02-21, 22:46
+
Cameron Gandevia 2013-02-22, 01:38
+
Hari Shreedharan 2013-01-23, 05:08