>From what I see in 0.94 and in the jira, it should work, there is nothing
fancy there.

moving to dev list btw, user in bcc.
On Wed, Jan 2, 2013 at 6:15 PM, Nicolas Liochon <[EMAIL PROTECTED]> wrote:

> If it works, it's ok: it's not going to give you wrong results. Just that
> it adds nothing to a plain mvn test.
> So if it worked for you on this patch, then you're done :-).
>
> This should be enough most most cases:
> mvn test
>
> If you want to play it safe, you will run all the tests before sending the
> patch.
> That's mvn test -P runAllTests
>
> And this should work. If you have a strange error, you can clean the env
> with a mvn clean install -DskipTests.
>
> 'P runAllTests' adds some extra tests and increases the parallelization,
> but does not change the environment.
>
>
> I'm gonna have a look at the JIRA you're working on to see if there
> something that could explain the issue you're having.
>
>
>  On Wed, Jan 2, 2013 at 6:03 PM, Jean-Marc Spaggiari <
> [EMAIL PROTECTED]> wrote:
>
>> for my code validation? What's the right way to run the tests on 0.94?
>
>
>

I agree, but Lars spent a lot of time to make sure the tests are
working fine, and I don't want him to yell at me if something is
broken ;)

dev-support/hbasetests.sh is running and seems to be working so far. I
can see all the tests passing fine.

If they all pass, I will submit the patch and re-run all the tests
with the mvn command line to see if it's faster.

Also, I ran mvn clean test -PrunAllTests
-Djava.net.preferIPv4Stack=true
-Dtest=org.apache.hadoop.hbase.master.cleaner.TestCleanerChore and it
passed too. So I will submit the patch now.

Thanks all,

JM

2013/1/2, Nicolas Liochon <[EMAIL PROTECTED]>:
> From what I see in 0.94 and in the jira, it should work, there is nothing
> fancy there.
>
> moving to dev list btw, user in bcc.
>
>
> On Wed, Jan 2, 2013 at 6:15 PM, Nicolas Liochon <[EMAIL PROTECTED]> wrote:
>
>> If it works, it's ok: it's not going to give you wrong results. Just that
>> it adds nothing to a plain mvn test.
>> So if it worked for you on this patch, then you're done :-).
>>
>> This should be enough most most cases:
>> mvn test
>>
>> If you want to play it safe, you will run all the tests before sending
>> the
>> patch.
>> That's mvn test -P runAllTests
>>
>> And this should work. If you have a strange error, you can clean the env
>> with a mvn clean install -DskipTests.
>>
>> 'P runAllTests' adds some extra tests and increases the parallelization,
>> but does not change the environment.
>>
>>
>> I'm gonna have a look at the JIRA you're working on to see if there
>> something that could explain the issue you're having.
>>
>>
>>  On Wed, Jan 2, 2013 at 6:03 PM, Jean-Marc Spaggiari <
>> [EMAIL PROTECTED]> wrote:
>>
>>> for my code validation? What's the right way to run the tests on 0.94?
>>
>>
>>
>

I ran both mvn and dev-support tests against 0.94.4RC1.

Here is dev-support results:
Results :
There are 127 small tests
There are 136 medium tests
There are 50 large tests

Tests run: 595, Failures: 0, Errors: 0, Skipped: 0
Tests run: 536, Failures: 0, Errors: 0, Skipped: 5
Tests run: 684, Failures: 0, Errors: 0, Skipped: 8

Medium and large (if selected) tests executed after 113 minutes
##########################
316 tests executed successfully
0 tests are in error
0 tests didn't finish

Tests in error are:
Tests that didn't finish are:

Execution time in minutes: 113
##########################

Here is mvn results
Tests run: 1220, Failures: 0, Errors: 0, Skipped: 13

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:06:45.841s
[INFO] Finished at: Thu Jan 03 11:42:35 EST 2013
[INFO] Final Memory: 44M/1185M
[INFO] ------------------------------------------------------------------------
mvn ran 1220 while dev-support ran 1800 (ish) tests.
mvn ran almost twice faster than dev-support!

Since mvn ran less tests than dev-support, is is still correct to rely
on its results? Since it's twice faster, I will prefer to use it
instead of dev-support...

JM

2013/1/2, Jean-Marc Spaggiari <[EMAIL PROTECTED]>:
> I agree, but Lars spent a lot of time to make sure the tests are
> working fine, and I don't want him to yell at me if something is
> broken ;)
>
> dev-support/hbasetests.sh is running and seems to be working so far. I
> can see all the tests passing fine.
>
> If they all pass, I will submit the patch and re-run all the tests
> with the mvn command line to see if it's faster.
>
> Also, I ran mvn clean test -PrunAllTests
> -Djava.net.preferIPv4Stack=true
> -Dtest=org.apache.hadoop.hbase.master.cleaner.TestCleanerChore and it
> passed too. So I will submit the patch now.
>
> Thanks all,
>
> JM
>
> 2013/1/2, Nicolas Liochon <[EMAIL PROTECTED]>:
>> From what I see in 0.94 and in the jira, it should work, there is nothing
>> fancy there.
>>
>> moving to dev list btw, user in bcc.
>>
>>
>> On Wed, Jan 2, 2013 at 6:15 PM, Nicolas Liochon <[EMAIL PROTECTED]>
>> wrote:
>>
>>> If it works, it's ok: it's not going to give you wrong results. Just
>>> that
>>> it adds nothing to a plain mvn test.
>>> So if it worked for you on this patch, then you're done :-).
>>>
>>> This should be enough most most cases:
>>> mvn test
>>>
>>> If you want to play it safe, you will run all the tests before sending
>>> the
>>> patch.
>>> That's mvn test -P runAllTests
>>>
>>> And this should work. If you have a strange error, you can clean the env
>>> with a mvn clean install -DskipTests.
>>>
>>> 'P runAllTests' adds some extra tests and increases the parallelization,
>>> but does not change the environment.
>>>
>>>
>>> I'm gonna have a look at the JIRA you're working on to see if there
>>> something that could explain the issue you're having.
>>>
>>>
>>>  On Wed, Jan 2, 2013 at 6:03 PM, Jean-Marc Spaggiari <
>>> [EMAIL PROTECTED]> wrote:
>>>
>>>> for my code validation? What's the right way to run the tests on 0.94?
>>>
>>>
>>>
>>
>