Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop >> mail # dev >> Review Request: SQOOP-450. Direct mode MySQL fails in some cases.


Copy link to this message
-
Review Request: SQOOP-450. Direct mode MySQL fails in some cases.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4121/
-----------------------------------------------------------

Review request for Sqoop.
Summary
-------

See Jira description for problem summary. The fix was to add the logic in the mapper sinks to parse out and ignore empty lines and those that begin with a comment marker.
This addresses bug SQOOP-450.
    https://issues.apache.org/jira/browse/SQOOP-450
Diffs
-----

  /src/java/org/apache/sqoop/mapreduce/MySQLDumpMapper.java 1295369

Diff: https://reviews.apache.org/r/4121/diff
Testing
-------

Ran DirectMySQLTest and MySQLAuthTest using mysqldump version 5.5.19 going against server version 5.1.61 where this problem is reproducible. Also tested against a system with MySQL version 5.5.20 where this problem was originally not reproducible.

Apart from this, ran the customary unit tests and third party tests.
Thanks,

Arvind