Hi,

In https://issues.apache.org/jira/browse/HBASE-6468 , Hadoop QA has
discovered six new findbug warnings introduced by the submitted patch.
I went through the report
https://builds.apache.org/job/PreCommit-HBASE-Build/2476//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html(also
checked rest of the 4 reports) but did not find any reference to the
files I touched in the commit.

How can I find which are these six new warnings?

Thanks.

-Shrijeet

Earlier in the year, we had a push to get rid of the findbugs warning
and we lowered the number of expected violations.  We weren't going to
strictly enforce it until after we go the number down to 0 (either by
excluding or by fixing problems).  Because of this, if the violations
don't touch the files you've modified, the 6 are likely not introduced
by you.

I wouldn't worry about it but if you'd like to contribute patches to
fix the findbugs problems we'd appreciate it.

Here's the parent issue -- most of have been quiet for a while so
comment if you'd like to address some.
https://issues.apache.org/jira/browse/HBASE-5598

Thanks,
Jon.

On Wed, Aug 1, 2012 at 10:49 PM, Shrijeet Paliwal
<[EMAIL PROTECTED]> wrote:
> Hi,
>
> In https://issues.apache.org/jira/browse/HBASE-6468 , Hadoop QA has
> discovered six new findbug warnings introduced by the submitted patch.
> I went through the report
> https://builds.apache.org/job/PreCommit-HBASE-Build/2476//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html(also
> checked rest of the 4 reports) but did not find any reference to the
> files I touched in the commit.
>
> How can I find which are these six new warnings?
>
> Thanks.
>
> -Shrijeet

--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// [EMAIL PROTECTED]

On Thu, Aug 2, 2012 at 9:29 AM, Jonathan Hsieh <[EMAIL PROTECTED]> wrote:

> Earlier in the year, we had a push to get rid of the findbugs warning
> and we lowered the number of expected violations.  We weren't going to
> strictly enforce it until after we go the number down to 0 (either by
> excluding or by fixing problems).  Because of this, if the violations
> don't touch the files you've modified, the 6 are likely not introduced
> by you.
>

Thanks for confirming Jon.

>
> I wouldn't worry about it but if you'd like to contribute patches to
> fix the findbugs problems we'd appreciate it.
> Here's the parent issue -- most of have been quiet for a while so
> comment if you'd like to address some.
> https://issues.apache.org/jira/browse/HBASE-5598
>
>
Sure thing.
> Thanks,
> Jon.
>
> On Wed, Aug 1, 2012 at 10:49 PM, Shrijeet Paliwal
> <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > In https://issues.apache.org/jira/browse/HBASE-6468 , Hadoop QA has
> > discovered six new findbug warnings introduced by the submitted patch.
> > I went through the report
> >
> https://builds.apache.org/job/PreCommit-HBASE-Build/2476//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html(also
> > checked rest of the 4 reports) but did not find any reference to the
> > files I touched in the commit.
> >
> > How can I find which are these six new warnings?
> >
> > Thanks.
> >
> > -Shrijeet
>
>
>
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // [EMAIL PROTECTED]
>