Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Accumulo, mail # dev - Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms


Copy link to this message
-
Re: Review Request 14972: ACCUMULO-1009 - add use of SSL for thrift comms
Michael Berman 2013-10-31, 20:28


> On Oct. 29, 2013, 3:25 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java, line 161
> > <https://reviews.apache.org/r/14972/diff/1/?file=371870#file371870line161>
> >
> >     there is also $ACCUMULO_CONF_DIR (not sure if I have the var name exactly correct)
>
> Michael Berman wrote:
>     I was wondering about this...  The code that I generalized that from only paid attention to $ACCUMULO_HOME and not the other one, and as I was looking through the codebase it seemed about 50/50 whether a given code path respected $ACCUMULO_CONF_DIR.  What is the intention there?  Is the plan for both to co-exist (and $ACCUMULO_CONF_DIR overrides $ACCUMULO_HOME/conf)?  Should we go through and make sure it's universally supported?
>
> Sean Busbey wrote:
>     everything should be using $ACCUMULO_CONF_DIR. if there are places that don't contain it, please file a bug that points to as many of them as possible. If you are adding in new code, please use it.
>    
>     There are some existing bugs for it not being set correctly in tests.
>    
>     I believe one of config.sh or bin/accumulo is responsible for handling the fall back to $ACCUMULO_HOME/conf when $ACCUMULO_CONF_DIR doesn't exist.

Filed ACCUMULO-1839 with the few remaining ones I could find.  There aren't many; looks like it's been cleaned up more since last I checked.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14972/#review27675
-----------------------------------------------------------
On Oct. 31, 2013, 2:35 p.m., John Vines wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14972/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2013, 2:35 p.m.)
>
>
> Review request for accumulo and Michael Berman.
>
>
> Bugs: ACCUMULO-1009
>     https://issues.apache.org/jira/browse/ACCUMULO-1009
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Michael Berman's October 13 patch for ACCUMULO-1009
>
>
> Diffs
> -----
>
>   .gitignore 1ffa452
>   core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 9247d56
>   core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java 5b5d041
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java bb5987d
>   core/src/main/java/org/apache/accumulo/core/client/impl/MasterClient.java 32c80f9
>   core/src/main/java/org/apache/accumulo/core/client/impl/ServerClient.java 218bd36
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchReaderIterator.java 0376304
>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java 0dd86bf
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportKey.java f07139d
>   core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java e7dabb5
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java bbbd0c3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java 908b8b3
>   core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java fe5003b
>   core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java c796cd2
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java 1cbb606
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java 727bfec
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java 992990d
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java 13f9708
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/ConfiguratorBase.java 73405c5
>   core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java 28cb0bd