Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Pig, mail # dev - Review Request 14274: PIG-2672 Optimize the use of DistributedCache


Copy link to this message
-
Re: Review Request 14274: PIG-2672 Optimize the use of DistributedCache
Aniket Mokashi 2013-09-25, 20:15


> On Sept. 24, 2013, 6:30 a.m., Cheolsoo Park wrote:
> > trunk/test/org/apache/pig/test/TestJobControlCompiler.java, line 161
> > <https://reviews.apache.org/r/14274/diff/1/?file=355177#file355177line161>
> >
> >     The following line is missing in the RB diff but it's in the attached the patch:
> >    
> >     properties.setProperty(PigConstants.PIG_SHARED_CACHE_ENABLED_KEY, "true");
> >    
> >     Just pointing it out.

I realized that we do not need to have PIG_SHARED_CACHE_ENABLED_KEY property for this. So, I removed this unnecessary property from the RB. I will attach the patch with the changes soon.
- Aniket
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14274/#review26342
-----------------------------------------------------------
On Sept. 21, 2013, 1:21 a.m., Aniket Mokashi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14274/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2013, 1:21 a.m.)
>
>
> Review request for pig, Cheolsoo Park, DanielWX DanielWX, Dmitriy Ryaboy, Julien Le Dem, and Rohini Palaniswamy.
>
>
> Bugs: PIG-2672
>     https://issues.apache.org/jira/browse/PIG-2672
>
>
> Repository: pig
>
>
> Description
> -------
>
> added jar.cache.location option
>
>
> Diffs
> -----
>
>   trunk/src/org/apache/pig/PigConstants.java 1525188
>   trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java 1525188
>   trunk/src/org/apache/pig/impl/PigContext.java 1525188
>   trunk/src/org/apache/pig/impl/io/FileLocalizer.java 1525188
>   trunk/test/org/apache/pig/test/TestJobControlCompiler.java 1525188
>
> Diff: https://reviews.apache.org/r/14274/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aniket Mokashi
>
>