Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
HBase, mail # dev - thrift vs thrift2


Copy link to this message
-
Re: thrift vs thrift2
lars hofhansl 2012-12-08, 05:27
Hmm... Interesting.Maybe the implementation is bad, but principally I don't see that. Why cache data twice when the in process thrift server could just access the data locally from the region server cache anyway?

Anyway, either we should fix it or remove it. (just to state the obvious :) )
I am not a fan of keeping non-functional code around in the hope that it might eventually get fixed.
-- Lars
________________________________
 From: Andrew Purtell <[EMAIL PROTECTED]>
To: "[EMAIL PROTECTED]" <[EMAIL PROTECTED]>; lars hofhansl <[EMAIL PROTECTED]>
Sent: Friday, December 7, 2012 9:06 PM
Subject: Re: thrift vs thrift2
 
IIRC the FB guys concluded the reverse, that it's better to provision
Thrift endpoints as a tier separate from RegionServers, so there can be
caching there, so the thrift servers in the RS don't bottleneck, etc.

On Saturday, December 8, 2012, lars hofhansl wrote:

> It's quite a useful experiment, though, standing up separate thrift
> servers adds more complexity to a deployment.
>
> If it is really abandoned we should just rip it out, no? Otherwise I'd
> think at least in principle that is useful (also considering potential
> future enhancement that we do knowing the thrift server is in process with
> the RegionServer).
>
> -- Lars
>
>
>
> ________________________________
>  From: Stack <[EMAIL PROTECTED] <javascript:;>>
> To: HBase Dev List <[EMAIL PROTECTED] <javascript:;>>
> Sent: Friday, December 7, 2012 3:16 PM
> Subject: Re: thrift vs thrift2
>
> On Fri, Dec 7, 2012 at 1:56 PM, Luke Lu <[EMAIL PROTECTED] <javascript:;>>
> wrote:
>
> > The embeded HRegionThriftServer should be ported to thrift2 before we
> > deprecate thrift1. FB's (and potentially others) c++ client requires
> > HRegionThriftServer.
> >
>
> HRTS is an abandoned experiment as I understand it so I closed HBASE-7302,
> the issue that would perpetuate it in thrift2.
> St.Ack

--
Best regards,

   - Andy

Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)