Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Plain View
Flume >> mail # dev >> Review Request: TestLoadBalancingSinkProcessor.testRoundRobinBackoffFailureRecovery is flaky, fails every once in a while...


+
Ted Malaska 2012-09-11, 15:29
+
Brock Noland 2012-09-11, 17:15
+
Brock Noland 2012-09-11, 17:15
Copy link to this message
-
Re: Review Request: TestLoadBalancingSinkProcessor.testRoundRobinBackoffFailureRecovery is flaky, fails every once in a while...
lol. nice

Question what is a mbean?  I found 1411 and it looks like fun.

On Tue, Sep 11, 2012 at 1:15 PM, Brock Noland <[EMAIL PROTECTED]> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7020/
>
> On September 11th, 2012, 5:15 p.m., *Brock Noland* wrote:
>
> Ship It!
>
>  I ran the test 200 times in a row and it passed every time.
>
>
> - Brock
>
> On September 11th, 2012, 3:29 p.m., Ted Malaska wrote:
>   Review request for Flume.
> By Ted Malaska.
>
> *Updated Sept. 11, 2012, 3:29 p.m.*
> Description
>
> It is possible that it is a clock issue.
>
> because s2 has to wait 2000 mil/s because of the following line
> state.restoreTime = now + Math.min(MAX_TIMEOUT, 1000 * (1 << state.sequentialFails));
>
> But then the test waits 2000 mil/s before starting the loop again.
>
> There is a chance that we reach the following if statement at only 2000 mil/s passing
>
> if (state.restoreTime < curTime) {
>
> So I'm going to increase the wait to 2001 mil/s.  That should do it.
>
>   *Bugs: * FLUME-1562 <https://issues.apache.org/jira/browse/FLUME-1562>
> Diffs
>
>    - flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java
>    (981f88e)
>
> View Diff <https://reviews.apache.org/r/7020/diff/>
>