Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Sqoop, mail # dev - Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.


Copy link to this message
-
Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
Jarek Cecho 2013-06-21, 22:57

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11983/#review22281
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this JIRA!

I would advise to stay consistent with other commands and keep the distinction between "command" and "function", eg. something like "start job", "stop job" and "status job". I know that we currently can't start anything else beyond job, but it might be interesting to keep that option for the future.
client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
<https://reviews.apache.org/r/11983/#comment45772>

    I think that this if is missing:
    
    ... && has_option(jid)

client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
<https://reviews.apache.org/r/11983/#comment45773>

    I would suggest to propagate the InterruptedException up. It will be eventually caught up by the shell and based on the user configuration printed with or without details (stack trace).

client/src/main/java/org/apache/sqoop/client/utils/OptionParser.java
<https://reviews.apache.org/r/11983/#comment45774>

    I do not feel that this refactoring is providing a huge value here. All the methods were already present only once in parent implementation of all commands and thus were reused.
Jarcec

- Jarek Cecho
On June 21, 2013, 5:51 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11983/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 5:51 p.m.)
>
>
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
>
>
> Description
> -------
>
> commit 5cc954a0e8594a1ddd667d06cc438100b44fe234
> Author: Mengwei Ding <[EMAIL PROTECTED]>
> Date:   Wed Jun 19 17:56:57 2013 -0700
>
>     SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.
>
> :100644 100644 056fcc8... 1020209... M client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 0538901... 519e571... M client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
> :100644 100644 6f62813... fce737c... M client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
> :100644 100644 04b240c... 7729363... M client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
> :100644 100644 cc4d546... fc6f4ff... M client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
> :100644 100644 18d3a70... c5b7911... M client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
> :100644 100644 736be20... 71553cd... M client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
> :100644 100644 32bca71... 3c9039a... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
> :100644 100644 b053339... 81a78b0... M client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
> :100644 100644 590e4e7... 4f9dfb4... M client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
> :100644 100644 bf26761... b148667... M client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
> :100644 100644 83f1c4f... aa87f20... M client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
> :000000 100644 0000000... c076882... A client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
> :000000 100644 0000000... ef2cec6... A client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
> :000000 100644 0000000... f483569... A client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
> :100644 000000 993bbde... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionCommand.java
> :100644 000000 04bcf45... 0000000... D client/src/main/java/org/apache/sqoop/client/shell/SubmissionStartFunction.java