Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Re: Review Request: FLUME-1741 ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around


Copy link to this message
-
Re: Review Request: FLUME-1741 ElasticSearch tests leave directory data/elasticsearch/nodes/ lying around
Mike Percy 2013-04-03, 21:47

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10251/#review18675
-----------------------------------------------------------
Hi Jeff,
Sorry for my limited knowledge of ES, it looks to me that when we set path.data = "target" I guess that means ES will store its data into the "target" directory under the flume-ng-elasticsearch-sink directory. Since target gets cleaned up automatically I think that's a good solution but I wonder if we shouldn't give one more level down so that ES doesn't accidentally stomp on some Maven build directories or something. i.e. set it to "target/es-test" or something, if that path will be automatically created.

Also, please indicate what level of testing was done, ideally "unit tests pass" and "manually verified that directories are being cleaned up".

Thanks!
Mike

- Mike Percy
On April 3, 2013, 5:18 a.m., Jeff jlord wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10251/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 5:18 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Modify elastic search nodebuilder to clean up test directories.
>
>
> This addresses bug FLUME-1741.
>     https://issues.apache.org/jira/browse/FLUME-1741
>
>
> Diffs
> -----
>
>   flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java 6d472cf
>
> Diff: https://reviews.apache.org/r/10251/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff jlord
>
>