Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Drill >> mail # dev >> Review Request 15284: Drill-278: Join predicate with CHAR types hit run-time error


Copy link to this message
-
Review Request 15284: Drill-278: Join predicate with CHAR types hit run-time error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15284/
-----------------------------------------------------------

Review request for drill.
Repository: drill-git
Description
-------

The patch is to fix the run-time error when drill runs merge join over join equal predicate with char type.

Prior to the fix, the generated code doCompareNextLeftKey(int leftIndex) will use directly the ValueHolder's value field, which does not work for VarBinaryHolder.

The fix will generate same code in doCompareNextLeftKey() as that in doCompare() when doing value comparison for VarBinaryHolder.
Diffs
-----

  exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java 1f5c707

Diff: https://reviews.apache.org/r/15284/diff/
Testing
-------
Thanks,

Jinfeng Ni