Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF


Copy link to this message
-
Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF
Mohammad Islam 2013-12-18, 03:16

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15654/
-----------------------------------------------------------

(Updated Dec. 18, 2013, 3:16 a.m.)
Review request for hive, Ashutosh Chauhan, Carl Steinbach, and Jitendra Pandey.
Changes
-------

Includes Carl's comments of moving the Test* file to correct location.
Bugs: HIVE-5829
    https://issues.apache.org/jira/browse/HIVE-5829
Repository: hive-git
Description
-------

Rewrite the UDFS *pads and *trim using GenericUDF.
Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java a895d65
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java bca1f26
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLTrim.java dc00cf9
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLpad.java d1da19a
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRTrim.java 2bcc5fa
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRpad.java 9652ce2
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTrim.java 490886d
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLTrim.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRTrim.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java PRE-CREATION
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTrim.java PRE-CREATION
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java eff251f
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLTrim.java PRE-CREATION
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java PRE-CREATION
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRTrim.java PRE-CREATION
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java PRE-CREATION
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFTrim.java PRE-CREATION

Diff: https://reviews.apache.org/r/15654/diff/
Testing
-------
Thanks,

Mohammad Islam