Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Hive, mail # dev - Review Request 16440: HIVE-6098: Merge Tez branch into trunk


Copy link to this message
-
Re: Review Request 16440: HIVE-6098: Merge Tez branch into trunk
Vikram Dixit Kumaraswamy 2014-01-08, 18:51

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16440/#review31347
-----------------------------------------------------------

trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
<https://reviews.apache.org/r/16440/#comment59818>

    Need to update java doc.

trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java
<https://reviews.apache.org/r/16440/#comment59817>

    No param conf.

trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
<https://reviews.apache.org/r/16440/#comment59831>

    spelling error "commone"

trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ReduceSinkMapJoinProc.java
<https://reviews.apache.org/r/16440/#comment59832>

    nit: reword the sentence.

trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java
<https://reviews.apache.org/r/16440/#comment59834>

    Could rename the mrTask to be more generic.

trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
<https://reviews.apache.org/r/16440/#comment59836>

    Why doesn't the same apply for the value table desc below?

trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java
<https://reviews.apache.org/r/16440/#comment59835>

    Comment needs to be fixed.

trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
<https://reviews.apache.org/r/16440/#comment59838>

    Could add some documentation explaining the use of this class.

trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
<https://reviews.apache.org/r/16440/#comment59839>

    Could it ever be a non-tez task?
- Vikram Dixit Kumaraswamy
On Jan. 7, 2014, 12:50 a.m., Gunther Hagleitner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16440/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 12:50 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive
>
>
> Description
> -------
>
> I think the Tez branch is at a point where we can consider merging it back into trunk after review.
> Tez itself has had its first release, most hive features are available on Tez and the test coverage is decent. There are a few known limitations, all of which can be handled in trunk as far as I can tell (i.e.: None of them are large disruptive changes that still require a branch.)
> Limitations:
> Union all is not yet supported on Tez
> SMB is not yet supported on Tez
> Bucketed map-join is executed as broadcast join (bucketing is ignored)
> Since the user is free to toggle hive.optimize.tez, it's obviously possible to just run these on MR.
> I am hoping to follow the approach that was taken with vectorization and shoot for a merge instead of single commit. This would retain history of the branch. Also in vectorization we required at least three +1s before merge, I'm hoping to go with that as well.
> I will add a combined patch to this ticket for review purposes (not for commit). I'll also attach instructions to run on a cluster if anyone wants to try.
>
>
> Diffs
> -----
>
>   trunk/ant/src/org/apache/hadoop/hive/ant/QTestGenTask.java 1556067
>   trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 1556067
>   trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1556067
>   trunk/conf/hive-default.xml.template 1556067
>   trunk/data/conf/tez/hive-site.xml UNKNOWN
>   trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm 1556067
>   trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm 1556067
>   trunk/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java 1556067
>   trunk/itests/qtest/pom.xml 1556067
>   trunk/itests/util/src/main/java/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java 1556067