Home | About | Sematext search-lucene.com search-hadoop.com
 Search Hadoop and all its subprojects:

Switch to Threaded View
Flume, mail # dev - Review Request: FLUME-1389: Flume gives opaque error if interceptor type not specified


Copy link to this message
-
Review Request: FLUME-1389: Flume gives opaque error if interceptor type not specified
Patrick Wendell 2012-07-23, 03:24

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6086/
-----------------------------------------------------------

Review request for Flume.
Description
-------

This checks for an unspecified interceptor type and returns a clear exception. Prior to this patch, an NPE is thrown if an interceptor is not specified.

I'm not sure if this is the right place to do this type of validation or if interceptors should be included in the existing validation framework somehow.
This addresses bug FLUME-1389.
    https://issues.apache.org/jira/browse/FLUME-1389
Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 53bfac1

Diff: https://reviews.apache.org/r/6086/diff/
Testing
-------

I re-built flume and tested with a bad config and ensure the error was thrown.
Thanks,

Patrick Wendell